fix: detect context on callable tool instances#2623
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
Code ReviewPR: fix: detect context on callable tool instances by @pragnyanramtha
Wallet: Code review for MCP Python SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_context_parameter()so callable object instances are inspected through their bound__call__method.Contextparameters from appearing in generated tool input schemas.Fixes #1974.
Validation
uv run pytest tests/server/mcpserver/test_tool_manager.py -quv run ruff check src/mcp/server/mcpserver/utilities/context_injection.py tests/server/mcpserver/test_tool_manager.pyuv run ruff format --check src/mcp/server/mcpserver/utilities/context_injection.py tests/server/mcpserver/test_tool_manager.pyuv run pyright src/mcp/server/mcpserver/utilities/context_injection.py tests/server/mcpserver/test_tool_manager.py