fix: re-register after auth server change#1011
Merged
Merged
Conversation
DaleSeo
marked this pull request as ready for review
July 18, 2026 14:00
DaleSeo
force-pushed
the
fix/conformance-auth-migration-dispatch
branch
from
July 21, 2026 14:01
e83fd8b to
204114a
Compare
alexhancock
approved these changes
Jul 21, 2026
Contributor
|
Only thing I can see is that now callers can no longer distinguish "AS changed, creds discarded" from "no creds present" as both now return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a quick follow-up to #1008. It routed
auth/authorization-server-migrationthrough the generic auth flow, which made its dedicated conformance path unreachable. Restoring that path exposed a second issue in #998: after clearing the DCR credentials tied to the previous authorization server,initialize_from_storereturned an issuer-mismatch error instead of allowing registration with the new server. This completes the authorization-server migration flow and adds a focused regression test.How Has This Been Tested?
Breaking Changes
None.
Types of changes
Checklist