Update Client.connect(transport:) to automatically send initialize request#100
Merged
Conversation
mattt
marked this pull request as ready for review
May 6, 2025 17:11
mattt
force-pushed
the
mattt/initialize-on-connect
branch
from
May 6, 2025 18:53
576445b to
e257521
Compare
mattt
force-pushed
the
mattt/initialize-on-connect
branch
from
May 26, 2025 12:18
e257521 to
297bf63
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #97 (comment)
Other SDKs have clients automatically send
initializemessage when connecting to a server. This PR updates our implementation to do the same. Beyond consistency, this helps mitigate an invisible time dependency / race condition for clients with streamable HTTP transport, as the client waits for a session ID before subscribing to SSE events. If the API consumer failed to callinitializeimmediately after connecting, this could result in SSE subscriptions timing out.This PR deprecates the existing
Client.initializemethod. This method will be removed in a future version (or more accurately, it will be madeprivateand replace the currentprivate func _initializemethod).