Skip to content

Fix Appworld install - #33

Merged
YunpengZhai merged 2 commits into
modelscope:mainfrom
Kanaricc:fix/appworld-install
Jan 27, 2026
Merged

YunpengZhai merged 2 commits into
modelscope:mainfrom
Kanaricc:fix/appworld-install

Conversation

@Kanaricc

Copy link
Copy Markdown
Collaborator

Description

Click 8.2.1 causes the install command of AppWorld to fail.

Closed #6 .

@Kanaricc Kanaricc added the bug Something isn't working label Jan 26, 2026
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @Kanaricc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a crucial fix for the Appworld environment setup by resolving a dependency conflict. It ensures that the installation process completes successfully by managing the version of the click library, which was previously causing failures.

Highlights

  • Appworld Installation Fix: This pull request resolves an installation failure for the Appworld environment. Specifically, it addresses an incompatibility with click version 8.2.1, which caused the install command to fail.
  • Dependency Pinning: To fix the installation issue, the setup.sh script now explicitly uninstalls any existing click package and then installs click==8.2.0, ensuring a compatible version is used for Appworld's Python dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an installation failure in Appworld caused by an incompatible version of the click package. The fix involves explicitly uninstalling the problematic version and installing a known working version (8.2.0). My review includes a suggestion to streamline this process. While the current approach is a valid hotfix, for long-term maintainability, it would be better to manage this dependency by pinning the version directly in the requirements.txt file.

Comment on lines +38 to +39
conda run -n appworld pip uninstall -y click
conda run -n appworld pip install click==8.2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These two commands can be simplified. The pip install <package>==<version> command will automatically handle downgrading the package if a newer version is installed, making the pip uninstall command redundant.

For a more robust and standard solution, consider adding click==8.2.0 directly to the env_service/environments/appworld/requirements.txt file. This makes the dependency explicit and allows pip's dependency resolver to manage versions correctly from the start, which is a best practice for Python projects.

Suggested change
conda run -n appworld pip uninstall -y click
conda run -n appworld pip install click==8.2.0
conda run -n appworld pip install click==8.2.0

@YunpengZhai
YunpengZhai merged commit 1b62be6 into modelscope:main Jan 27, 2026
@Kanaricc
Kanaricc deleted the fix/appworld-install branch January 30, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.sh: appworld install fails with "Secondary flag" TypeError

2 participants