Repository navigation
refactor(session): inject a lifecycle clock - #953
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Aug 31, 2026
benvinegar
force-pushed
the
refactor/session-lifecycle-clock
branch
from
August 31, 2026 19:51
302512e to
68ab759
Compare
benvinegar
marked this pull request as ready for review
August 31, 2026 23:54
Contributor
Greptile SummaryThe PR introduces a runtime-neutral lifecycle clock and threads one native instance through session startup, daemon polling, authentication, heartbeat, and reconnect scheduling.
Confidence Score: 5/5The PR appears safe to merge with no concrete changed-code failure identified. Native behavior remains equivalent to the replaced timers, timer ownership is explicitly disposable, and the shared clock is consistently threaded through startup, launcher, and connection lifecycle paths with focused coverage. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
UI[Interactive process] --> Clock[Native lifecycle clock]
Clock --> Client[SessionBrokerClient]
Client --> Startup[Startup retry]
Client --> Launcher[Daemon launch and health polling]
Client --> Connection[SessionBrokerConnection]
Connection --> Handshake[Authentication deadline]
Connection --> Heartbeat[Heartbeat interval]
Connection --> Reconnect[Reconnect delay]
Client --> Stop[Client stop]
Stop --> Startup
Stop --> Connection
Reviews (1): Last reviewed commit: "refactor(session): inject a lifecycle cl..." | Re-trigger Greptile |
benvinegar
force-pushed
the
refactor/session-lifecycle-clock
branch
from
September 1, 2026 03:33
68ab759 to
4879381
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Base branch:
refactor/session-startup-states. Review only the fourth commit for this PR.Validation
bun run typecheckbun run lintbun run deps:checkbun run test:session-broker-node— 3 passbun run check:packDeliberate boundaries
No Effect, package-global scheduler, or test-only public declarations are introduced.
This PR description was generated by Pi using gpt-5.6-sol