Repository navigation
MOEN-47952: 13.0.0 release fix - #150
Merged
Merged
Conversation
|
🚪 Hodor is reviewing this PR... 👀 |
There was a problem hiding this comment.
Branching & CFR: patch/MOEN-47952-ios-warning-fix — category: patch, impact: Neutral CFR ✅
Summary: Registers the MoEInstallationIdAvailable event name in the iOS bridge's supportedEvents array so RN doesn't reject it as unsupported, fixing a console warning when the Firebase Installation Id event fires on iOS.
Quality Gates: All passed. Small, well-scoped diff (11 lines / 4 files).
Verification done:
- Confirmed
kInstallationIdAvailable→@"MoEInstallationIdAvailable"matches the JS-side constantMOE_FIREBASE_INSTALLATION_ID_AVAILABLE = "MoEInstallationIdAvailable"insdk/core/src/index.ts, so the string used to register the event in nativesupportedEventslines up with what the JSNativeEventEmitterlistens for. - New constant/array entry placement is consistent with the existing pattern (e.g.
kAuthenticationError). - CHANGELOG entry follows the required pending-block format from
RELEASING.md(# Release Date/## Release Version/ tagged- iOS\n - [patch] ...bullet) — will be picked up correctly by the release automation.
Issues Found: None blocking. 🔴 0 ·
What's Good:
- Minimal, targeted fix matching the exact pattern used for the other supported events.
- Changelog entry correctly tagged per the repo's release automation rules.
Regression Risk: Low — purely additive (one array entry + one constant pair), no existing behavior changed.
Hodor holds the gate... and lets this one through. Small, clean fix. ✅
abhishek-engg-mobilesdk
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://moengagetrial.atlassian.net/browse/MOEN-47952
Added missing event MoEInstallationIdAvailable in iOS native supported event list to avoid warning
Updated peer dependency v13.0.0 in package.json