Skip to content

MOEN-47952: 13.0.0 release fix - #150

Merged
umangmoe merged 2 commits into
developmentfrom
patch/MOEN-47952-ios-warning-fix
Oct 6, 2026
Merged

umangmoe merged 2 commits into
developmentfrom
patch/MOEN-47952-ios-warning-fix

Conversation

@RakshithaAcharya

@RakshithaAcharya RakshithaAcharya commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

https://moengagetrial.atlassian.net/browse/MOEN-47952

Added missing event MoEInstallationIdAvailable in iOS native supported event list to avoid warning
Updated peer dependency v13.0.0 in package.json

@moe-hodor

moe-hodor Bot commented Oct 6, 2026

Copy link
Copy Markdown

🚪 Hodor is reviewing this PR... 👀

@moe-hodor moe-hodor Bot added branch:patch Weekly maintenance / support tickets (neutral CFR) cfr:neutral Change Failure Rate: neutral impact labels Oct 6, 2026

@moe-hodor moe-hodor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branching & CFR: patch/MOEN-47952-ios-warning-fix — category: patch, impact: Neutral CFR ✅

Summary: Registers the MoEInstallationIdAvailable event name in the iOS bridge's supportedEvents array so RN doesn't reject it as unsupported, fixing a console warning when the Firebase Installation Id event fires on iOS.

Quality Gates: All passed. Small, well-scoped diff (11 lines / 4 files).

Verification done:

  • Confirmed kInstallationIdAvailable → @"MoEInstallationIdAvailable" matches the JS-side constant MOE_FIREBASE_INSTALLATION_ID_AVAILABLE = "MoEInstallationIdAvailable" in sdk/core/src/index.ts, so the string used to register the event in native supportedEvents lines up with what the JS NativeEventEmitter listens for.
  • New constant/array entry placement is consistent with the existing pattern (e.g. kAuthenticationError).
  • CHANGELOG entry follows the required pending-block format from RELEASING.md (# Release Date / ## Release Version / tagged - iOS\n - [patch] ... bullet) — will be picked up correctly by the release automation.

Issues Found: None blocking. 🔴 0 · ⚠️ 0 · 💡 0

What's Good:

  • Minimal, targeted fix matching the exact pattern used for the other supported events.
  • Changelog entry correctly tagged per the repo's release automation rules.

Regression Risk: Low — purely additive (one array entry + one constant pair), no existing behavior changed.

Hodor holds the gate... and lets this one through. Small, clean fix. ✅

@RakshithaAcharya RakshithaAcharya changed the title MOEN-47952: Fixed iOS warning for missing event name MOEN-47952: 13.0.0 release fix Oct 6, 2026
@umangmoe
umangmoe merged commit 5637b73 into development Oct 6, 2026
6 checks passed
@umangmoe
umangmoe deleted the patch/MOEN-47952-ios-warning-fix branch October 6, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:patch Weekly maintenance / support tickets (neutral CFR) cfr:neutral Change Failure Rate: neutral impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants