Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing a wrong vowel sign in
சோonly turned that part red. Monkeytype was highlighting each Unicode code point separately, even though the browser displays them as one character. When I reproduced it in Firefox, I saw half the glyph turn red, while the issue report described the whole word turning white.I used
Intl.Segmenterto find the boundaries of visible characters in the target word, so a mistake in any part marks the whole character as incorrect. This only changes the highlighting. Nothing else changes. I also added tests for Tamil and combining characters in other scripts.The tests pass, and I checked the behaviour in Firefox. Some Indic conjuncts, such as
க்ஷandஶ்ரீ, aren't covered yet, and character grouping may differ between browsers.Closes #8453
Before:

After:
