Skip to content

Remove obsolete libmicrohttpd notice - #5403

Merged
mattleibow merged 2 commits into
mono:mainfrom
Saad-elnagar:fix/remove-libmicrohttpd-notice
Oct 27, 2026
Merged

mattleibow merged 2 commits into
mono:mainfrom
Saad-elnagar:fix/remove-libmicrohttpd-notice

Conversation

@Saad-elnagar

Copy link
Copy Markdown
Contributor

Description

Remove the obsolete libmicrohttpd third-party license notice from External-Dependency-Info.txt, since the dependency has already been removed.

Related issues

Fixes #5401

Required skia PR

None.

Areas affected

  • Build, packaging, or CI

Changes

Remove the outdated libmicrohttpd license section from External-Dependency-Info.txt. No source code or public API changes.

Testing

  • Ran git diff --check successfully.
  • Packed the Linux native-assets project and verified that the generated THIRD-PARTY-NOTICES.txt no longer contains libmicrohttpd and still contains libwebp.

Note: This verifies the generated notice content; it was not a full native-assets packaging validation.

Saad-elnagar and others added 2 commits October 20, 2026 14:16
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

📦 Try the packages from this PR

Warning

Do not run these scripts without first reviewing the code in this PR.

Step 1 — Download the packages

bash / macOS / Linux:

curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 5403

PowerShell / Windows:

iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 5403"

Step 2 — Add the local NuGet source

dotnet nuget add source ~/.skiasharp/hives/pr-5403/packages --name skiasharp-pr-5403
More options
Option Description
--successful-only / -SuccessfulOnly Only use successful builds
--force / -Force Overwrite previously downloaded packages
--list / -List List available artifacts without downloading
--build-id ID / -BuildId ID Download from a specific build

Or download manually from Azure Pipelines — look for the nuget artifact on the build for this PR.

Remove the source when you're done:

dotnet nuget remove source skiasharp-pr-5403

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@Saad-elnagar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mattleibow
mattleibow merged commit f009766 into mono:main Oct 27, 2026
127 of 128 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in SkiaSharp Backlog Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Still libmicrohttpd dependency is not removed properly from External-Dependency-Info.txt file

2 participants