Make MessageBufferU constructor public, close #210#212
Merged
Conversation
So it can be used to unpack read-only ByteBuffers
Contributor
Author
|
The test fails on Travis because it runs with JDK6. The test assumes JDK7 to demonstrate that a read-only ByteBuffer can't normally be read, as it elects regular MessageBuffer implementation. But with JDK6, it elects MessageBufferU. Fixing. |
Contributor
Author
|
Test fixed. I sadly had to move the test to the |
Contributor
Author
There was a problem hiding this comment.
Fixed. Do you want me to squash the commits?
Member
|
No need to squash the commits. They are small enough |
Member
|
Looks good. |
xerial
added a commit
that referenced
this pull request
Mar 18, 2015
Make MessageBufferU constructor public, close #210
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it can be used to unpack read-only ByteBuffers