Fixes #38: Add IntegerValue.mostSuccinctMessageFormat#258
Merged
Conversation
Member
Author
Member
|
@xerial LGTM overall. I have a question about a test: Does forAll method generate values based on the types at random? If the answer is positive, I think we should add a test with values on the borders of types explicitly. Thoughts? |
Member
Author
|
A nice thing about |
Member
|
OIC. +1, merging this shortly. |
oza
added a commit
that referenced
this pull request
Jun 29, 2015
Fixes #38: Add IntegerValue.mostSuccinctMessageFormat
Member
|
Thanks @xerial for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a utility method to IntegerValue to detect the most succinct integer type. This is useful when user wants to know which get method (e.g., getByte, getInt, etc. ) should be used to extract values.