Repository navigation
[docs] Add notistack demo to the snackbar page - #13685
Merged
Merged
Conversation
iamhosseindhv
changed the title
Collaborator
|
There is some guidance here on solving the peer dependency issue: #13659 (comment) :) |
Contributor
Author
|
Thanks @joshwooding. The issue is fixed now and live demo is working. ❤️ |
oliviertassinari
added
docs
oliviertassinari
changed the title
oliviertassinari
approved these changes
Nov 27, 2018
Member
|
@iamhosseindhv Thank you, keep up the good work with this project :). |
Contributor
Author
|
Thanks @oliviertassinari. So great to have a demo on the official website. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up this issue, I have added a simple example of notistack to Snackbar documentation page.
However, this PR is not fully functional since
notistackneeds@material-ui/coreas a peer dependency. So I wanted to make sure if I can add@material-ui/coreas a devDependency to package.json ?Thanks.