Skip to content

[TextareaAutosize] Fix 166ms resize update lag - #37135

Merged
michaldudak merged 8 commits into
mui:masterfrom
qburst:#36866--Fix-multiline-TextField-unstable-height
Aug 30, 2023
Merged

michaldudak merged 8 commits into
mui:masterfrom
qburst:#36866--Fix-multiline-TextField-unstable-height

Conversation

@amal-qb

@amal-qb amal-qb commented May 2, 2023 •

Copy link
Copy Markdown
Contributor

@mui-bot

mui-bot commented May 2, 2023 •

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-37135--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ccf26d7

@zannager zannager added the scope: text field Changes related to the text field. label May 2, 2023
@zannager
zannager requested a review from michaldudak May 2, 2023 13:54
@amal-qb

amal-qb commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

@michaldudak Can you please review and merge this PR?

@amal-qb

amal-qb commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

Hi @michaldudak ,
Can you review this please?

@michaldudak

Copy link
Copy Markdown
Member

The issue is still present (although not as apparent as before). I suggest removing debounce from the handleResize call.

@amal-qb

amal-qb commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

@michaldudak I have removed debounce from handleResize call. Sorry for committing the fix so late.

@amal-qb

amal-qb commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

@michaldudak Can you please review the changes?

@ZeeshanTamboli

ZeeshanTamboli commented Aug 10, 2023 •

Copy link
Copy Markdown
Member

@amal-qb Can you please merge with the latest master branch so that all the CI jobs run?

@amal-qb

amal-qb commented Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

@ZeeshanTamboli Done

Comment thread docs/pages/base-ui/api/use-modal.json
@amal-qb
amal-qb requested a review from michaldudak August 30, 2023 07:25
@michaldudak

Copy link
Copy Markdown
Member

Thanks for the fix!

@michaldudak
michaldudak merged commit e788009 into mui:master Aug 30, 2023
@oliviertassinari oliviertassinari added component: TextareaAutosize The React component. package: @mui/base Specific to @mui/base (legacy). type: bug It doesn't behave as expected. labels Aug 30, 2023
@oliviertassinari oliviertassinari changed the title [TextField] Fix unstable height of memoized multiline TextField component [TextareaAutosize] Fix 166ms resize update lag Aug 30, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@oliviertassinari

Copy link
Copy Markdown
Member

Test case added in #38728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: TextareaAutosize The React component. package: @mui/base Specific to @mui/base (legacy). scope: text field Changes related to the text field. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TextareaAutosize] Instability in height of memoized multiline TextField component

7 participants