Repository navigation
[Timeline] Add alternate reverse position - #37311
Merged
Merged
Conversation
Netlify deploy previewBundle size report |
Contributor
Author
|
@gzrae @mnajdova |
mnajdova
changed the title
mnajdova
reviewed
May 29, 2023
mnajdova
left a comment
mnajdova
left a comment
Member
There was a problem hiding this comment.
The implementation looks great. The only thing I could notice that can be improved is the API surface - the prop name.
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: abhinavkmrru <86560460+abhinavkmrru@users.noreply.github.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: abhinavkmrru <86560460+abhinavkmrru@users.noreply.github.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: abhinavkmrru <86560460+abhinavkmrru@users.noreply.github.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: abhinavkmrru <86560460+abhinavkmrru@users.noreply.github.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: abhinavkmrru <86560460+abhinavkmrru@users.noreply.github.com>
…-> alternate-reverse},{positionAlternateRevert -> positionAlternateReverse},{AlternateRevertTimeline -> AlternateReverseTimeline}]
…kmrru/material-ui into abhinavkmrru-issue#37275
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
type: new feature
mnajdova
approved these changes
Jun 21, 2023
mnajdova
left a comment
mnajdova
left a comment
Member
There was a problem hiding this comment.
Great job! Thanks for the contribution 🙏
Contributor
Author
|
Dear Marija and team,
Thanks for your support, it was my first contribution to open-source.
I had a great experience and looking forward to contributing more.
Thanks & Regards,
Abhinav Kumar
mail to: ***@***.***
Website: abhiravinody.web.app
…On Wed, Jun 21, 2023 at 3:41 PM Marija Najdova ***@***.***> wrote:
***@***.**** approved this pull request.
Great job! Thanks for the contribution 🙏
—
Reply to this email directly, view it on GitHub
<#37311 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUUM5THXVZGJST3T2DX2MC3XMLCD7ANCNFSM6AAAAAAYFL5JHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37275