Skip to content

[docs-infra] Fix demos border radius - #37658

Merged
oliviertassinari merged 1 commit into
mui:masterfrom
oliviertassinari:docs-fix-border-demos
Jun 20, 2023
Merged

oliviertassinari merged 1 commit into
mui:masterfrom
oliviertassinari:docs-fix-border-demos

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Jun 20, 2023 •

Copy link
Copy Markdown
Member

Fix visual bug from #37319, it's most noticeable when using "bg": true

Screenshot 2023-06-20 at 23 59 52

https://deploy-preview-37319--material-ui.netlify.app/material-ui/react-grid/

After

Screenshot 2023-06-21 at 00 00 46

https://deploy-preview-37658--material-ui.netlify.app/material-ui/react-grid/

It's hard to really appreciate the difference from the above screenshots seen on a desktop. It's more noticeable opening the after/before links on a mobile phone.

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). labels Jun 20, 2023
@oliviertassinari oliviertassinari changed the title [docs] Fix demos border radius [docs-infra] Fix demos border radius Jun 20, 2023
@oliviertassinari
oliviertassinari requested a review from zanivan June 20, 2023 22:03
@mui-bot

mui-bot commented Jun 20, 2023 •

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-37658--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 2d38c8b

@oliviertassinari
oliviertassinari requested review from danilo-leal and removed request for zanivan June 20, 2023 22:08

@danilo-leal danilo-leal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Opened a similar PR fixing some Demo container-related stuff too: #37659

@oliviertassinari
oliviertassinari merged commit 6ada767 into mui:master Jun 20, 2023
@oliviertassinari
oliviertassinari deleted the docs-fix-border-demos branch June 20, 2023 22:34
@oliviertassinari oliviertassinari added the type: regression A bug, but worse, it used to behave as expected. label Jun 24, 2023
@oliviertassinari oliviertassinari removed the type: bug It doesn't behave as expected. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants