Skip to content

Fix/chart screenshots not inserting - #2

Merged
mx00 merged 3 commits into
mainfrom
fix/chart-screenshots-not-inserting
May 25, 2026
Merged

mx00 merged 3 commits into
mainfrom
fix/chart-screenshots-not-inserting

Conversation

@mx00

@mx00 mx00 commented May 25, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes chart screenshot upload and screenshot-to-trade linking issues in TradeNote.

Fixed

  • Fixed 413 PayloadTooLargeError during screenshot uploads
  • Increased Express body size limits to support larger chart screenshots
  • Fixed manual chart screenshots not attaching to the correct trade
  • Fixed fallback handling when tradeTagsDateUnix is undefined
  • Fixed screenshot naming to use the exact trade ID
  • Fixed manual uploads replacing existing screenshots instead of creating new ones

Technical Changes

  • Added 50mb Express JSON/urlencoded limits

  • Patched screenshot linking logic in:

    • src/utils/daily.js
    • src/utils/screenshots.js
    • src/views/Daily.vue
    • index.mjs
  • Added patch-tradenote-screenshot-upload.sh

Result

  • Automatic TradingView replay screenshots upload correctly
  • Manual chart screenshots attach correctly to trades
  • Multiple screenshots can now be attached to the same trade
  • Daily/Dashboard views continue working correctly

@mx00
mx00 merged commit 72a5a11 into main May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant