Skip to content

Support multiple screenshots per trade modal - #3

Merged
mx00 merged 1 commit into
mainfrom
fix/multiple-trade-screenshots-modal
May 25, 2026
Merged

mx00 merged 1 commit into
mainfrom
fix/multiple-trade-screenshots-modal

Conversation

@mx00

@mx00 mx00 commented May 25, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes trade details modal to support multiple screenshots per trade in TradeNote.

Fixed

  • Trade details modal previously displayed only one screenshot
  • Entry/exit screenshots were both stored correctly but only the first screenshot was rendered in the modal
  • Manual screenshot uploads could overwrite existing screenshots instead of displaying all linked screenshots

Technical Changes

  • Replaced single screenshot lookup using .find() with .filter()
  • Added support for screenshot.multiple array in the trade details modal
  • Updated Vue rendering logic to display all screenshots attached to the trade using v-for
  • Preserved backward compatibility with existing screenshot data

Result

  • Entry and exit screenshots now both appear in trade details
  • Multiple screenshots per trade are fully supported
  • Daily view and trade modal behavior are now consistent

@mx00
mx00 merged commit cbe84a0 into main May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant