Skip to content

Remove proxy "200 Connection established" header - #86

Merged
nategood merged 1 commit into
nategood:masterfrom
joaomachado:master
Jul 30, 2013
Merged

nategood merged 1 commit into
nategood:masterfrom
joaomachado:master

Conversation

@joaomachado

Copy link
Copy Markdown
Contributor

No description provided.

nategood added a commit that referenced this pull request Jul 30, 2013
Remove proxy "200 Connection established" header
@nategood
nategood merged commit 5013e13 into nategood:master Jul 30, 2013
@stavros-zavrakas

Copy link
Copy Markdown

When we just pulled the changes it broke all the requests that we make. When the hasProxy function is called we have the error: Undefined offset: 10004. Do we have to make a special initialization to the request just before we call the send method? This is the call that we make:

$http_response = \Httpful\Request::get($final_path . '?' . $get_url)->send();

@racingDeveloper

Copy link
Copy Markdown
Contributor

Hi svabael, i had the same problem. I've send a very little fix!

@nategood

Copy link
Copy Markdown
Owner

Ah. Weird. Are you using a proxy? I'll have to dig into it shortly.
On Jul 31, 2013 9:02 AM, "Stavros" notifications@github.com wrote:

When we just pulled the changes it broke all the requests that we make.
When the hasProxy function is called we have the error: Undefined offset:
10004. Do we have to make a special initialization to the request just
before we call the send method? This is the call that we make:

$http_response = \Httpful\Request::get($final_path . '?' .
$get_url)->send();

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/86#issuecomment-21859759
.

@racingDeveloper

Copy link
Copy Markdown
Contributor

Hi nate,

no, the issue comes up when you doesn't use a proxy. It's a notice, so many will not "note" this :-)

@stavros-zavrakas

Copy link
Copy Markdown

No, I don't use a proxy. Maybe we have to check if is empty the array of additional_curl_opts when we return back the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants