fix(Execute Shell Command): Fix exception return type inconsistency and print formatting (fixes #463) - #464
Open
Prayas340 wants to merge 2 commits into
Open
Conversation
…ing and add tests (fixes ndleah#463)
…ing and add tests (fixes ndleah#463)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #463
Changes Proposed
(b'', 105)so tuple unpackingresult, statusworks consistently without crashing withTypeError.errbytes cleanly before output.test_shell_command_non_zero_statusfor non-zero status / failing shell commands.