Conversation
The docs state that 'rows' defaults to 1, and it did until the prop fallback refactor in 7638301 dropped the final default. Since then a multiline TextInput without 'rows' or 'numberOfLines' renders a textarea with no 'rows' attribute, so browsers apply their default of 2 rows.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 60637fe:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for
TextInputsayrowsdefaults to1, and it did:numberOfLinesdefaulted to1until 6795738 moved the default ontorows, and 7638301 then removed it fromrowsto letnumberOfLinesact as a fallback, leaving no final default. Since 0.19 amultilineinput withoutrows/numberOfLinesrenders a<textarea>with norowsattribute, so browsers apply their own default of 2 rows, and a multiline input starts two lines tall on web while it starts one line tall on iOS and Android.The fix restores the final fallback to
1in therows ?? numberOfLines ?? 1chain. A test renders<TextInput multiline />and checksrows="1".npm run unit,lintandformatpass for the package;flowcould not be run locally (flow-bin has no arm64 build), so relying on CI for it.