feat: support spore nft by homura · Pull Request #2810 · nervosnetwork/neuron

homura · 2023-08-21T13:28:28Z

Resolves: Magickbase/neuron-public-issues#252

Limitation with The Light Client

expected: [ID][Cluster Name] Spore
actual: [ID][Cluster ID] Spore

When working with the light client in this PR, the [Cluster Name] part is displayed as a Cluster ID. This is because it is difficult to resolve the cluster cell from a spore cell, which is not owned by the wallet. To search the cluster cell that derives the spore cell, we need to:

Decode the cluster_id from a spore cell's data if the spore is born from a cluster
Build the type script filter of code_hash: cluster_code_hash, data: data1, args: cluster_id and search in the CKB indexer
Repeat step 2 with another version of cluster scripts if the cluster cell is not found.

This limitation appears because Neuron only subscribes to lock scripts owned by a wallet, while the cluster cell may not belong to it.

Although we can subscribe to the cluster cells not owned by the wallet, it will make the light client heavier. If we subscribe to more scripts to make the features the same as the full node, the light client will lose its lightness. Therefore, I believe that the trade-off here may be acceptable.

Notes

Cluster cells can NOT be destroyed

# Conflicts: # yarn.lock

homura · 2023-08-30T09:14:18Z

/package
Packaging for test is done in 6022935795. @homura

homura · 2023-08-30T10:24:29Z

I found there were some circular dependencies in Neuron, maybe we should find a way to avoid it

Details

 neuron-wallet git:(spore) ✗ dpdm --circular --tree false src/**/*.ts     
✔ [221/221] Analyze done!
• Circular Dependencies
  01) src/models/keys/key.ts -> src/models/keys/address.ts
  02) src/models/chain/transaction.ts -> src/models/offline-sign.ts
  03) src/database/chain/entities/transaction.ts -> src/database/chain/entities/input.ts
  04) src/database/chain/entities/transaction.ts -> src/database/chain/entities/output.ts
  05) src/database/chain/entities/asset-account.ts -> src/database/chain/entities/sudt-token-info.ts
  06) src/services/tx/transaction-service.ts -> src/utils/export-history.ts
  07) src/services/addresses.ts -> src/services/tx/index.ts -> src/services/tx/transaction-service.ts -> src/utils/export-history.ts
  08) src/controllers/app/menu.ts -> src/controllers/export-debug.ts -> src/services/addresses.ts -> src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/controllers/sync-api.ts -> src/services/node.ts -> src/services/ckb-runner.ts -> src/services/settings.ts
  09) src/services/addresses.ts -> src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/controllers/sync-api.ts -> src/services/node.ts -> src/services/ckb-runner.ts -> src/services/indexer.ts -> src/database/chain/index.ts -> src/services/sync-progress.ts -> src/services/wallets.ts
  10) src/block-sync-renderer/index.ts -> src/controllers/sync-api.ts -> src/services/node.ts -> src/services/ckb-runner.ts -> src/services/indexer.ts -> src/database/chain/index.ts -> src/services/sync-progress.ts -> src/services/wallets.ts
  11) src/services/ckb-runner.ts -> src/services/indexer.ts -> src/services/monitor/index.ts -> src/services/monitor/ckb-monitor.ts
  12) src/block-sync-renderer/index.ts -> src/controllers/sync-api.ts -> src/services/node.ts -> src/services/ckb-runner.ts -> src/services/indexer.ts -> src/services/monitor/index.ts -> src/services/monitor/ckb-monitor.ts -> src/services/light-runner.ts
  13) src/services/node.ts -> src/services/ckb-runner.ts -> src/services/indexer.ts -> src/services/monitor/index.ts -> src/services/monitor/ckb-monitor.ts
  14) src/services/node.ts -> src/services/ckb-runner.ts -> src/services/indexer.ts
  15) src/block-sync-renderer/index.ts -> src/controllers/sync-api.ts -> src/services/node.ts -> src/services/ckb-runner.ts -> src/services/indexer.ts
  16) src/block-sync-renderer/index.ts -> src/controllers/sync-api.ts -> src/services/node.ts -> src/services/ckb-runner.ts
  17) src/services/addresses.ts -> src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts
  18) src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/tx-status-listener.ts
  19) src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/sync/queue.ts
  20) src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/sync/queue.ts -> src/services/asset-account-service.ts
  21) src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/sync/queue.ts -> src/services/asset-account-service.ts -> src/services/transaction-sender.ts
  22) src/services/addresses.ts -> src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/sync/queue.ts -> src/services/asset-account-service.ts -> src/services/transaction-sender.ts
  23) src/services/addresses.ts -> src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/sync/queue.ts -> src/services/asset-account-service.ts -> src/services/transaction-sender.ts -> src/services/hardware/index.ts -> src/services/hardware/ledger.ts -> src/services/hardware/hardware.ts
  24) src/services/transaction-sender.ts -> src/services/hardware/index.ts -> src/services/hardware/ledger.ts -> src/services/hardware/hardware.ts
  25) src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/sync/queue.ts -> src/services/asset-account-service.ts -> src/services/transaction-sender.ts
  26) src/services/tx/index.ts -> src/services/tx/transaction-generator.ts -> src/services/cells.ts -> src/services/live-cell-service.ts -> src/block-sync-renderer/index.ts -> src/block-sync-renderer/task.ts -> src/block-sync-renderer/sync/queue.ts -> src/services/asset-account-service.ts
  27) src/services/addresses.ts -> src/services/tx/index.ts -> src/services/tx/transaction-generator.ts
  28) src/controllers/app/index.ts -> src/controllers/api.ts -> src/controllers/app/show-window.ts

# Conflicts: # yarn.lock

homura · 2023-09-07T11:26:05Z

/package
Packaging for test is done in 6109098199. @homura

# Conflicts: # packages/neuron-wallet/package.json # yarn.lock

homura · 2023-10-27T08:39:30Z

@silySuper

1.In full node mode,NFT can be sent to itself(input address equals output address).In expect ,it is an useful operation.

I'm a bit confused about this point. Does it say that we should prevent users from transferring spores to the same address?

2.In full node mode,when NFT is sent to address it shows successfully,but in address book it balance does not change.In expect the output address balance will change.

I think is a feature instead of a bug because Nueron only treats the cells without data as spendable cells, so I suggest we keep the same here. @Keith-CY @yanguoyu What are your ideas about this point?

neuron/packages/neuron-wallet/src/services/cells.ts

Lines 85 to 86 in f3cc18a

    
                       output.hasData = false AND 
        
                       output.typeHash is null

silySuper · 2023-10-27T08:45:26Z

@silySuper

1.In full node mode,NFT can be sent to itself(input address equals output address).In expect ,it is an useful operation.

I'm a bit confused about this point. Does it say that we should prevent users from transferring spores to the same address?

2.In full node mode,when NFT is sent to address it shows successfully,but in address book it balance does not change.In expect the output address balance will change.

I think is a feature instead of a bug because Nueron only treats the cells without data as spendable cells, so I suggest we keep the same here. @Keith-CY @yanguoyu What are your ideas about this point?

neuron/packages/neuron-wallet/src/services/cells.ts

Lines 85 to 86 in f3cc18a

output.hasData = false AND

output.typeHash is null

For No.1 send NFT to itself is a useful operation? @Danie0918 if it is not ,it is better to have a tip for users.

yanguoyu · 2023-10-28T09:27:48Z

@silySuper

1.In full node mode,NFT can be sent to itself(input address equals output address).In expect ,it is an useful operation.

I'm a bit confused about this point. Does it say that we should prevent users from transferring spores to the same address?

2.In full node mode,when NFT is sent to address it shows successfully,but in address book it balance does not change.In expect the output address balance will change.

I think is a feature instead of a bug because Nueron only treats the cells without data as spendable cells, so I suggest we keep the same here. @Keith-CY @yanguoyu What are your ideas about this point?

neuron/packages/neuron-wallet/src/services/cells.ts

Lines 85 to 86 in f3cc18a

output.hasData = false AND

output.typeHash is null

I'm sure that balance does not include cells' capacity that the cells include data. Neurons will not cost the cells that have data when transferring CKB.

Danie0918 · 2023-10-30T08:28:19Z

@silySuper

1.In full node mode,NFT can be sent to itself(input address equals output address).In expect ,it is an useful operation.

I'm a bit confused about this point. Does it say that we should prevent users from transferring spores to the same address?

2.In full node mode,when NFT is sent to address it shows successfully,but in address book it balance does not change.In expect the output address balance will change.

I think is a feature instead of a bug because Nueron only treats the cells without data as spendable cells, so I suggest we keep the same here. @Keith-CY @yanguoyu What are your ideas about this point?

neuron/packages/neuron-wallet/src/services/cells.ts

Lines 85 to 86 in f3cc18a

output.hasData = false AND

output.typeHash is null

For No.1 send NFT to itself is a useful operation? @Danie0918 if it is not ,it is better to have a tip for users.

This is something that can be initiated normally without prompting, similar to sending CKB.

homura · 2023-11-06T08:54:13Z

Screen.Recording.2023-11-06.at.16.44.16.mov

Transferring spores via the light client is supported, please have a check, @silySuper

silySuper · 2023-11-07T01:13:37Z

/package
Packaging for test is done in 6778653910. @silySuper

silySuper · 2023-11-08T09:10:19Z

@silySuper

1.In full node mode,NFT can be sent to itself(input address equals output address).In expect ,it is an useful operation.

I'm a bit confused about this point. Does it say that we should prevent users from transferring spores to the same address?

2.In full node mode,when NFT is sent to address it shows successfully,but in address book it balance does not change.In expect the output address balance will change.

I think is a feature instead of a bug because Nueron only treats the cells without data as spendable cells, so I suggest we keep the same here. @Keith-CY @yanguoyu What are your ideas about this point?

neuron/packages/neuron-wallet/src/services/cells.ts

Lines 85 to 86 in f3cc18a

output.hasData = false AND

output.typeHash is null

For No.1 send NFT to itself is a useful operation? @Danie0918 if it is not ,it is better to have a tip for users.

This is something that can be initiated normally without prompting, similar to sending CKB.

For No.1,send CKB will have tip when send and receive is same.So send NFT need tip @Danie0918 ?

Danie0918 · 2023-11-09T01:58:26Z

@silySuper

1.In full node mode,NFT can be sent to itself(input address equals output address).In expect ,it is an useful operation.

I'm a bit confused about this point. Does it say that we should prevent users from transferring spores to the same address?

2.In full node mode,when NFT is sent to address it shows successfully,but in address book it balance does not change.In expect the output address balance will change.

I think is a feature instead of a bug because Nueron only treats the cells without data as spendable cells, so I suggest we keep the same here. @Keith-CY @yanguoyu What are your ideas about this point?

neuron/packages/neuron-wallet/src/services/cells.ts

Lines 85 to 86 in f3cc18a

output.hasData = false AND

output.typeHash is null

For No.1 send NFT to itself is a useful operation? @Danie0918 if it is not ,it is better to have a tip for users.

This is something that can be initiated normally without prompting, similar to sending CKB.

For No.1,send CKB will have tip when send and receive is same.So send NFT need tip @Danie0918 ?

If you can receive the NFT normally you don't need to be prompted, it's a limitation of the APC account here, isn't it?

silySuper · 2023-11-09T08:54:53Z

No.3 Verified.

silySuper · 2023-11-09T09:01:57Z

No.1 and No.2 not need to change.

silySuper · 2023-11-09T09:16:45Z

Offline sign can not send successfully when transaction is signed and export in light client,appear uncertainly

2023-11-09.17.13.06.mov

silySuper · 2023-11-13T07:29:46Z

Light client sync failed. @homura
Testing package is this:
https://github.com/nervosnetwork/neuron/actions/runs/6778653910

This is the debug log.
neuron_debug_1699860419192.zip

homura · 2023-11-13T12:38:17Z

This is the debug log.

Hi @silySuper, did you run more than one light client at the same during the test? If yes, then the light client may not be working correctly.

Failed to open rocksdb: Error { message: "IO error: While lock file:/... Resource temporarily unavailable" }.
...
function call error: Error: connect ECONNREFUSED 127.0.0.1:9001, retry 2

silySuper · 2023-11-15T03:14:40Z

This is the debug log.

Hi @silySuper, did you run more than one light client at the same during the test? If yes, then the light client may not be working correctly.
Failed to open rocksdb: Error { message: "IO error: While lock file:/... Resource temporarily unavailable" }.
...
function call error: Error: connect ECONNREFUSED 127.0.0.1:9001, retry 2 

Today from activity monitor,there is no ckb process and can sync.

silySuper · 2023-11-15T03:17:49Z

Send feature has verified.

homura · 2023-11-15T08:43:19Z

Today from activity monitor,there is no ckb process and can sync.

So you mean that the sync of the light client is working well, right?

Send feature has verified.

Does it mean that the PR is completely tested?

silySuper · 2023-11-15T08:46:39Z

Today from activity monitor,there is no ckb process and can sync.

So you mean that the sync of the light client is working well, right?

Send feature has verified.

Does it mean that the PR is completely tested?

Yes

homura added 6 commits August 21, 2023 21:27

feat: support spore nft

8586fdd

feat: display cluster name in asset list

918b913

Merge remote-tracking branch 'origin/develop' into spore

c0f3a4a

# Conflicts: # yarn.lock

chore: update lockfile

f4bbc4a

fix: avoid circular dep

0b657e1

fix: avoid circular dep

634ffaf

homura marked this pull request as ready for review August 30, 2023 09:12

homura requested review from Keith-CY, devchenyan and yanguoyu August 30, 2023 09:18

Merge remote-tracking branch 'origin/develop' into spore

174c10b

yanguoyu reviewed Sep 5, 2023

View reviewed changes

Comment thread packages/neuron-wallet/src/models/asset-account-info.ts Outdated

Comment thread packages/neuron-ui/src/utils/formatters.ts Outdated

homura added 2 commits September 5, 2023 14:42

refactor: rm unused devnet config of spore

aab28b1

refactor: rm unused spore's unbound mark

dbc5a5b

Keith-CY requested a review from WhiteMinds September 5, 2023 17:01

Keith-CY reviewed Sep 5, 2023

View reviewed changes

homura added 5 commits September 6, 2023 14:46

refactor: rm unsuitable button type

9c56406

chore: fix dep version

b177e73

chore: reason for rpc is required when getCustomizedAsset

eb88b79

test: make sporeFormatter testable

667bcab

refactor: switch-case to more clear

a385812

Keith-CY approved these changes Sep 6, 2023

View reviewed changes

yanguoyu approved these changes Sep 7, 2023

View reviewed changes

homura added 2 commits September 7, 2023 11:44

Merge remote-tracking branch 'origin/develop' into spore

55e7a93

# Conflicts: # yarn.lock

chore: update lock file

a1b3698

devchenyan approved these changes Sep 8, 2023

View reviewed changes

yanguoyu mentioned this pull request Sep 12, 2023

Supporting Spore Magickbase/neuron-public-issues#252

Closed

Merge remote-tracking branch 'origin/develop' into spore

e0e88d7

# Conflicts: # packages/neuron-wallet/package.json # yarn.lock

homura force-pushed the spore branch from 3f2ad9d to e0e88d7 Compare October 27, 2023 12:55

homura added 2 commits November 6, 2023 16:50

feat: support the nft transferring in light client mode

a4e6f46

Merge remote-tracking branch 'origin/develop' into spore

350ef66

homura added 2 commits November 15, 2023 16:51

Merge remote-tracking branch 'origin/develop' into spore

869aaf9

refactor: migrate NodeService to NetworksService

5107afd

homura force-pushed the spore branch from 2f694ec to 5107afd Compare November 15, 2023 09:15

Keith-CY added this pull request to the merge queue Nov 15, 2023

Merged via the queue into nervosnetwork:develop with commit 8abdab0 Nov 15, 2023

homura deleted the spore branch November 15, 2023 10:42

Keith-CY mentioned this pull request Nov 23, 2023

Release v0.112.0 #2956

Merged

Keith-CY mentioned this pull request Dec 6, 2023

Release v0.112.0 #2973

Merged

Uh oh!

Conversation

homura commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Limitation with The Light Client

Notes

Uh oh!

homura commented Aug 30, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

homura commented Aug 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

homura commented Sep 7, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

homura commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silySuper commented Oct 27, 2023

Uh oh!

yanguoyu commented Oct 28, 2023

Uh oh!

Danie0918 commented Oct 30, 2023

Uh oh!

homura commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silySuper commented Nov 7, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silySuper commented Nov 8, 2023

Uh oh!

Danie0918 commented Nov 9, 2023

Uh oh!

silySuper commented Nov 9, 2023

Uh oh!

silySuper commented Nov 9, 2023

Uh oh!

silySuper commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silySuper commented Nov 13, 2023

Uh oh!

homura commented Nov 13, 2023

Uh oh!

silySuper commented Nov 15, 2023

Uh oh!

silySuper commented Nov 15, 2023

Uh oh!

homura commented Nov 15, 2023

Uh oh!

silySuper commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

homura commented Aug 21, 2023 •

edited

Loading

homura commented Aug 30, 2023 •

edited by github-actions Bot

Loading

homura commented Sep 7, 2023 •

edited by github-actions Bot

Loading

homura commented Oct 27, 2023 •

edited

Loading

homura commented Nov 6, 2023 •

edited

Loading

silySuper commented Nov 7, 2023 •

edited by github-actions Bot

Loading

silySuper commented Nov 9, 2023 •

edited

Loading