Skip to content

fix: Show the migrate ckb data dialog - #2869

Merged
yanguoyu merged 3 commits into
nervosnetwork:developfrom
yanguoyu:fix-migrate-dialog
Oct 17, 2023
Merged

fix: Show the migrate ckb data dialog#2869
yanguoyu merged 3 commits into
nervosnetwork:developfrom
yanguoyu:fix-migrate-dialog

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor

If we need to run ckb migrate for the ckb data, the neuron will show a dialog to help users migrate ckb data. Once users have selected migrate, the neuron will auto-migrate next time if the before-migrate version is the same. The migrating version will be saved in the electron local storage, if we want to show the migrate dialog again, we can delete the local storage, which can be found at /Users/${username}/Library/Application Support/Neuron/Local Storage.

migrateing.mov

@Keith-CY

Copy link
Copy Markdown
Contributor

I remembered that migrating will be displayed where progress sat in the deprecated UI

@yanguoyu

Copy link
Copy Markdown
Contributor Author

I remembered that migrating will be displayed where progress sat in the deprecated UI

Of course, may be because it was too fast that the migrating status was not shown. But I find the migrating status will not change to syncing status, I will fix it and upload the full process video.

@yanguoyu

Copy link
Copy Markdown
Contributor Author

The full migration video:

migrate-full.mov

@yanguoyu
yanguoyu requested a review from Keith-CY October 13, 2023 00:28
Comment thread packages/neuron-ui/src/components/PageContainer/index.tsx
Comment thread packages/neuron-ui/src/services/subjects.ts
@silySuper

silySuper commented Oct 13, 2023

Copy link
Copy Markdown

/package
Packaging for test is done in 6503496425. @silySuper

@silySuper

silySuper commented Oct 16, 2023

Copy link
Copy Markdown

/package
Packaging for test is done in 6527826934. @silySuper

@silySuper

Copy link
Copy Markdown

Comment thread packages/neuron-ui/src/utils/hooks/index.ts Outdated
@yanguoyu
yanguoyu added this pull request to the merge queue Oct 17, 2023
Merged via the queue into nervosnetwork:develop with commit 62b11cc Oct 17, 2023
@yanguoyu
yanguoyu deleted the fix-migrate-dialog branch October 17, 2023 02:13
@Keith-CY Keith-CY mentioned this pull request Oct 17, 2023
@MarkoSARIC1990

Copy link
Copy Markdown

How can we do migration on Neuron, i cant understand from the video, thank you

@yanguoyu

yanguoyu commented Nov 1, 2024

Copy link
Copy Markdown
Contributor Author

How can we do migration on Neuron, i cant understand from the video, thank you

Neuron should open a migration dialog for the user to choose to migrate if migration is needed. If the dialog does not show,
or we can manually migrate refer to #2868 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants