Skip to content

fix: Avoid unexpected dialog shown.#2928

Merged
yanguoyu merged 3 commits into
nervosnetwork:developfrom
yanguoyu:fix-unexpected-dialog
Nov 22, 2023
Merged

fix: Avoid unexpected dialog shown.#2928
yanguoyu merged 3 commits into
nervosnetwork:developfrom
yanguoyu:fix-unexpected-dialog

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

To avoid unexpected dialog that notifies the user of an external node shown.

  1. Set the process to null when the started pid equals the current process pid.
  2. Stop the get tip number when switching the network and start after starting the node.
  3. Add debounce time to start node, that is avoid the user switching the internal network faster.

@yanguoyu

yanguoyu commented Nov 10, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 6822238187. @yanguoyu

@yanguoyu yanguoyu mentioned this pull request Nov 10, 2023
Closed
Keith-CY
Keith-CY reviewed Nov 17, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/services/ckb-runner.ts Outdated
@Keith-CY

Keith-CY commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

In what situations will the dialog be displayed mistakenly?

@yanguoyu
yanguoyu force-pushed the fix-unexpected-dialog branch from 2a5a17d to 2e863d1 Compare November 17, 2023 04:17
@yanguoyu

yanguoyu commented Nov 17, 2023

Copy link
Copy Markdown
Contributor Author

In what situations will the dialog be displayed mistakenly?

When the connectionStatusSubject broadcasts true for the last selected node. So I restart the subscribe which gets the tip number when the network switches.

@Keith-CY

Keith-CY commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

In what situations will the dialog be displayed mistakenly?

When the connectionStatusSubject broadcasts true for the last selected node. So I restart the subscribe which gets the tip number when the network switches.

Got it

@yanguoyu
yanguoyu requested a review from Keith-CY November 17, 2023 06:00
Keith-CY
Keith-CY reviewed Nov 19, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/services/ckb-runner.ts
@silySuper

silySuper commented Nov 21, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package
Packaging for test is done in 6938651819. @silySuper

homura
homura reviewed Nov 21, 2023
View reviewed changes
Comment thread packages/neuron-ui/src/utils/getSyncStatus.ts
@yanguoyu
yanguoyu force-pushed the fix-unexpected-dialog branch from ef79364 to 26fa8f2 Compare November 21, 2023 08:30
@yanguoyu
yanguoyu requested a review from homura November 21, 2023 08:44
@yanguoyu
yanguoyu added this pull request to the merge queue Nov 22, 2023
Merged via the queue into nervosnetwork:develop with commit dffd921 Nov 22, 2023
@yanguoyu
yanguoyu deleted the fix-unexpected-dialog branch November 22, 2023 01:07
@Keith-CY Keith-CY mentioned this pull request Nov 23, 2023
Merged
@Keith-CY Keith-CY mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds
@devchenyan devchenyan Awaiting requested review from devchenyan
@silySuper silySuper Awaiting requested review from silySuper
2 more reviewers
@Keith-CY Keith-CY Keith-CY approved these changes
@homura homura homura approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanguoyu @Keith-CY @silySuper @homura