Skip to content

fix: Actions on receive address is confusing#2999

Merged
yanguoyu merged 7 commits into
developfrom
fix-305
Jan 10, 2024
Merged

fix: Actions on receive address is confusing#2999
yanguoyu merged 7 commits into
developfrom
fix-305

Conversation

@devchenyan

Copy link
Copy Markdown
Contributor

issue: Magickbase/neuron-public-issues#305

Screen-2023-12-22-221250.mp4

Comment thread packages/neuron-ui/src/components/Receive/index.tsx Outdated
@devchenyan

devchenyan commented Dec 24, 2023

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 7312862068. @devchenyan

@Keith-CY

Keith-CY commented Dec 29, 2023

Copy link
Copy Markdown
Contributor

/package
Packaging for test is done in 7353308428. @Keith-CY

@silySuper

Copy link
Copy Markdown

In Assets Account page ,I can not see the modification.

2023-12-29.16.28.48.mov

@devchenyan

devchenyan commented Jan 2, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 7381464798. @devchenyan

@silySuper

Copy link
Copy Markdown

The copy function of QR code in receive page is copy address actually,not copy QR code.The same to copy function in assets account page.

2024-01-03.10.20.16.mov

@devchenyan

Copy link
Copy Markdown
Contributor Author

The copy function of QR code in receive page is copy address actually,not copy QR code.The same to copy function in assets account page.

2024-01-03.10.20.16.mov

image

@Danie0918

Copy link
Copy Markdown

The copy function of QR code in receive page is copy address actually,not copy QR code.The same to copy function in assets account page.
2024-01-03.10.20.16.mov

image

Both copy and download here are for QR code, PRD here may have caused a misunderstanding, the meaning here is that the previous design did not have clear boundaries easily let the user misinterpret it as a copy of the address.

@devchenyan

devchenyan commented Jan 4, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 7407168469. @devchenyan

@silySuper

Copy link
Copy Markdown

The package above: light client alaways show sync not started yet,main.log shows [error] Sync:ChildProcess: /private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/2782174D-62A0-4ACB-9D84-E89C6F46716D/d/Neuron 3.app/Contents/Resources/app/node_modules/typeorm/error/TypeORMError.js:9
var _this = _super.call(this, message) || this;
^

QueryFailedError: SQLITE_ERROR: no such column: blockStartNumber

this is debug log:
neuron_debug_1704419520948.zip

@yanguoyu

yanguoyu commented Jan 5, 2024

Copy link
Copy Markdown
Contributor

The package above: light client alaways show sync not started yet,main.log shows [error] Sync:ChildProcess: /private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/2782174D-62A0-4ACB-9D84-E89C6F46716D/d/Neuron 3.app/Contents/Resources/app/node_modules/typeorm/error/TypeORMError.js:9 var _this = _super.call(this, message) || this; ^

QueryFailedError: SQLITE_ERROR: no such column: blockStartNumber

this is debug log: neuron_debug_1704419520948.zip

You may cause this by running the #2992 result. This PR will migrate the DB file. You can try again after deleting the DB file.

@silySuper

silySuper commented Jan 5, 2024

Copy link
Copy Markdown

The package above: light client alaways show sync not started yet,main.log shows [error] Sync:ChildProcess: /private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/2782174D-62A0-4ACB-9D84-E89C6F46716D/d/Neuron 3.app/Contents/Resources/app/node_modules/typeorm/error/TypeORMError.js:9 var _this = _super.call(this, message) || this; ^
QueryFailedError: SQLITE_ERROR: no such column: blockStartNumber
this is debug log: neuron_debug_1704419520948.zip

You may cause this by running the #2992 result. This PR will migrate the DB file. You can try again after deleting the DB file.

OK,to check this Neuron (view) ,I have open the neuron for about two days,after sync finished ,then I will check the copy enhancement.

@yanguoyu
yanguoyu added this pull request to the merge queue Jan 10, 2024
Merged via the queue into develop with commit 8c0d834 Jan 10, 2024
@yanguoyu
yanguoyu deleted the fix-305 branch January 10, 2024 02:46
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
* fix: issue 305

* fix: add clearTimeout

* fix: AddressQrCodeWithCopyZone

* fix: CopyQrCode

---------

Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants