Skip to content

fix: Migrate legacy acp to new acp account - #3062

Merged
Keith-CY merged 5 commits into
nervosnetwork:developfrom
yanguoyu:fix-legacy_acp
May 6, 2024
Merged

fix: Migrate legacy acp to new acp account#3062
Keith-CY merged 5 commits into
nervosnetwork:developfrom
yanguoyu:fix-legacy_acp

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#360
Support migrating legacy ACP to the new or existing account, add cell dep when migrating legacy ACP cell. Remove migrated legacy ACP dialog.

  1. Migrate to new
migrate-to-new-account.mov
  1. Migrate to exist
migrate-to-exist-account.mov

Here is the wallet that includes legacy ACP sudt cell

image

@Danie0918

Copy link
Copy Markdown

@homura @devchenyan Please have a review.

@silySuper

silySuper commented Apr 17, 2024

Copy link
Copy Markdown

/package
Packaging for test is done in 8717790831. @silySuper

@Keith-CY

Keith-CY commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

/package
Packageing failed in 8874291463. @Keith-CY

@silySuper

silySuper commented Apr 29, 2024

Copy link
Copy Markdown

/package
Packaging for test is done in 8874801472. @silySuper

@silySuper

Copy link
Copy Markdown

1.dialog is still stay.
截屏2024-04-30 16 56 37

2.migrate into a new account shows error
截屏2024-04-30 16 50 33

2024-04-30.16.51.05.mov

3.migrate into exist shows error
截屏2024-04-30 16 55 12

@yanguoyu

Copy link
Copy Markdown
Contributor Author

1.dialog is still stay. 截屏2024-04-30 16 56 37

I guess you do not use the right package, I downloaded the package and it does not show the dialog. And the words in your picture are not used in this PR.

@Keith-CY
Keith-CY added this pull request to the merge queue May 6, 2024
Merged via the queue into nervosnetwork:develop with commit 0a3d8a9 May 6, 2024
@yanguoyu
yanguoyu deleted the fix-legacy_acp branch May 6, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants