Skip to content

feat: Support lock window for Neuron - #3064

Merged
yanguoyu merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-lock-window
Apr 29, 2024
Merged

feat: Support lock window for Neuron#3064
yanguoyu merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-lock-window

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#318

lock-window.mov

@yanguoyu yanguoyu mentioned this pull request Mar 8, 2024
Closed
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 8, 2024
View reviewed changes
Comment thread packages/neuron-wallet/src/services/settings.ts Fixed
Comment thread packages/neuron-wallet/src/services/settings.ts Fixed
@yanguoyu
yanguoyu force-pushed the feat-lock-window branch 2 times, most recently from 87c9bcd to 0a8c5cc Compare March 8, 2024 05:01
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 8, 2024
View reviewed changes
Comment thread packages/neuron-wallet/src/services/settings.ts
@Danie0918

Danie0918 commented Apr 1, 2024

Copy link
Copy Markdown

@homura @devchenyan Please have a review.

homura
homura reviewed Apr 3, 2024
View reviewed changes
Comment thread packages/neuron-ui/src/components/GeneralSetting/LockWindowDialog/hooks.ts
@Danie0918

Danie0918 commented Apr 15, 2024

Copy link
Copy Markdown

@homura Please have a review.

homura
homura approved these changes Apr 18, 2024
View reviewed changes
Comment thread packages/neuron-ui/src/components/GeneralSetting/LockWindowDialog/index.tsx
@silySuper

silySuper commented Apr 28, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package
Packageing failed in 8864545175. @silySuper

@silySuper

silySuper commented Apr 28, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package
Packaging for test is done in 8864654721. @silySuper

@silySuper

silySuper commented Apr 28, 2024

Copy link
Copy Markdown

1.UI icon is not aligning to its text,and the border is strange.
截屏2024-04-28 15 57 12

2.The tip need show window.
截屏2024-04-28 16 50 38

截屏2024-04-28 16 05 24

3.Lock window can not support command+L.
截屏2024-04-28 16 32 15

@yanguoyu

yanguoyu commented Apr 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@silySuper

1.UI icon is not aligning to its text,and the border is strange.

fixed by 0ccb57b

2.The tip need show window.
image

@Danie0918 should we change the content? I can not find the reply to this comment.

3.Lock window can not support command+L.

@silySuper I download the package from #3064 (comment). And the command +L is available on my Mac. Do you try to click Command + L on Mac or Ctrl + L on Windows?

@Danie0918

Danie0918 commented Apr 29, 2024

Copy link
Copy Markdown

2.The tip need show window.
image

@Danie0918 should we change the content? I can not find the reply to this comment.

#Magickbase/neuron-public-issues#318 (comment)

PRD：https://cvhb3r.axshare.com/#g=1&p=pin

Yes, 'Neuron's window is locked.' would be better.

@silySuper

silySuper commented Apr 29, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package
Packaging for test is done in 8874064562. @silySuper

@yanguoyu

yanguoyu commented Apr 29, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 8874152463. @yanguoyu

@silySuper

silySuper commented Apr 29, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package
Packaging for test is done in 8874295650. @silySuper

@silySuper

silySuper commented Apr 29, 2024

Copy link
Copy Markdown

1.verified
2.verified

@yanguoyu
yanguoyu added this pull request to the merge queue Apr 29, 2024
Merged via the queue into nervosnetwork:develop with commit 128e425 Apr 29, 2024
@yanguoyu
yanguoyu deleted the feat-lock-window branch April 29, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Awaiting requested review from Keith-CY
3 more reviewers
@homura homura homura approved these changes
@devchenyan devchenyan devchenyan approved these changes
@silySuper silySuper silySuper approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yanguoyu @Danie0918 @silySuper @Keith-CY @homura @devchenyan @github-advanced-security