feat: Keep screen awake by yanguoyu · Pull Request #3066 · nervosnetwork/neuron

yanguoyu · 2024-03-09T13:22:02Z

Add an option for users to keep the screen awake. Refer to Magickbase/neuron-public-issues#319

Because the screen recording cannot capture the screen lock, the video was not uploaded.

Danie0918 · 2024-04-01T02:23:08Z

@homura Please have a review.

Keith-CY · 2024-04-09T04:06:57Z

/package

Packaging for test is done in 8610166731. @Keith-CY

Keith-CY · 2024-04-10T08:05:30Z

Any update on this @silySuper

silySuper · 2024-04-10T08:38:32Z

It is testing ,and will finish today in expect.

silySuper · 2024-04-10T12:15:42Z

After about 1 hour Lock screen ，sync process is increased only about 1%；and sync can not change when unlock screen.
an error show in main.log

[error] Unhandled Rejection in task: Reason: AbortError: This operation was aborted
at Object.fetch (node:internal/deps/undici/undici:11372:11)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async LightRPC.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/node_modules/@ckb-lumos/rpc/lib/method.js:57:19)
at async LightSynchronizer.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:88:28)
at async LightSynchronizer.upsertTxHashes (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:104:29)
at async LightSynchronizer.synchronize (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:76:29)
at async LightSynchronizer.initSync (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:202:13)
[2024-04-10T11:13:24.972Z] [error] Sync:ChildProcess: [2024-04-10T11:13:24.967Z] [error] Unhandled Rejection in task: Reason: AbortError: This operation was aborted
at Object.fetch (node:internal/deps/undici/undici:11372:11)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async LightRPC.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/node_modules/@ckb-lumos/rpc/lib/method.js:57:19)
at async LightSynchronizer.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:88:28)
at async LightSynchronizer.upsertTxHashes (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:104:29)
at async LightSynchronizer.synchronize (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:76:29)
at async LightSynchronizer.initSync (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:202:13)

main.log

yanguoyu · 2024-04-11T02:07:59Z

After about 1 hour Lock screen ，sync process is increased only about 1%；and sync can not change when unlock screen. an error show in main.log

[error] Unhandled Rejection in task: Reason: AbortError: This operation was aborted at Object.fetch (node:internal/deps/undici/undici:11372:11) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async LightRPC.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/node_modules/@ckb-lumos/rpc/lib/method.js:57:19) at async LightSynchronizer.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:88:28) at async LightSynchronizer.upsertTxHashes (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:104:29) at async LightSynchronizer.synchronize (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:76:29) at async LightSynchronizer.initSync (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:202:13) [2024-04-10T11:13:24.972Z] [error] Sync:ChildProcess: [2024-04-10T11:13:24.967Z] [error] Unhandled Rejection in task: Reason: AbortError: This operation was aborted at Object.fetch (node:internal/deps/undici/undici:11372:11) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async LightRPC.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/node_modules/@ckb-lumos/rpc/lib/method.js:57:19) at async LightSynchronizer.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:88:28) at async LightSynchronizer.upsertTxHashes (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:104:29) at async LightSynchronizer.synchronize (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:76:29) at async LightSynchronizer.initSync (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:202:13)

main.log

[2024-04-10T10:57:52.809Z] [info]  Database:	saved synced block #2110000
[2024-04-10T11:13:24.967Z] [error] Unhandled Rejection in task:	Reason: AbortError: This operation was aborted
    at Object.fetch (node:internal/deps/undici/undici:11372:11)

Hi, when is the window locked? From the log, after 15 minutes in normal logs, the error log shows. This may be not a problem with this PR, but I will still find out what happened.

silySuper · 2024-04-11T02:34:37Z

After about 1 hour Lock screen ，sync process is increased only about 1%；and sync can not change when unlock screen. an error show in main.log
[error] Unhandled Rejection in task: Reason: AbortError: This operation was aborted at Object.fetch (node:internal/deps/undici/undici:11372:11) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async LightRPC.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/node_modules/@ckb-lumos/rpc/lib/method.js:57:19) at async LightSynchronizer.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:88:28) at async LightSynchronizer.upsertTxHashes (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:104:29) at async LightSynchronizer.synchronize (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:76:29) at async LightSynchronizer.initSync (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:202:13) [2024-04-10T11:13:24.972Z] [error] Sync:ChildProcess: [2024-04-10T11:13:24.967Z] [error] Unhandled Rejection in task: Reason: AbortError: This operation was aborted at Object.fetch (node:internal/deps/undici/undici:11372:11) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async LightRPC.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/node_modules/@ckb-lumos/rpc/lib/method.js:57:19) at async LightSynchronizer.getTransactions (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:88:28) at async LightSynchronizer.upsertTxHashes (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:104:29) at async LightSynchronizer.synchronize (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:76:29) at async LightSynchronizer.initSync (/Users/chllp/Downloads/Neuron 3.app/Contents/Resources/app/dist/block-sync-renderer/sync/light-synchronizer.js:202:13)
main.log
[2024-04-10T10:57:52.809Z] [info]  Database:	saved synced block #2110000
[2024-04-10T11:13:24.967Z] [error] Unhandled Rejection in task:	Reason: AbortError: This operation was aborted
    at Object.fetch (node:internal/deps/undici/undici:11372:11)
Hi, when is the window locked? From the log, after 15 minutes in normal logs, the error log shows. This may be not a problem with this PR, but I will still find out what happened.

From about 19：00 to 20:00 yesterday

yanguoyu · 2024-04-11T04:48:39Z

@silySuper Do you set the keep screen awake on when the screen is locked?

silySuper · 2024-04-11T04:52:31Z

yes

yanguoyu · 2024-04-11T04:57:44Z

yes

So, the actual problem is when you set the keep the screen awake on, the screen is still locked after the preference locked time ends? Have you ever minimized the Neuron window?

silySuper · 2024-04-11T06:34:27Z

yes

So, the actual problem is when you set the keep the screen awake on, the screen is still locked after the preference locked time ends? Have you ever minimized the Neuron window?

I can not remember whether I have minimized the Neuron window.Because I have not see any tips about Neuron window operation before,so I do not pay close attention to this point.I have record a new screen recording before locking screen.

2024-04-11.14.02.37.mov

After half an hour:

2024-04-11.14.30.43.mov

main.log

yanguoyu · 2024-04-11T07:41:21Z

yes

So, the actual problem is when you set the keep the screen awake on, the screen is still locked after the preference locked time ends? Have you ever minimized the Neuron window?

I can not remember whether I have minimized the Neuron window.Because I have not see any tips about Neuron window operation before,so I do not pay close attention to this point.I have record a new screen recording before locking screen.

2024-04-11.14.02.37.mov
After half an hour:

2024-04-11.14.30.43.mov
main.log

And after half an hour I will offer a sync process picture.

To test this PR, I suggest setting the Computer's locked time to 1 minute, but not half an hour, then we will test this PR quickly but not need to wait for half an hour.

silySuper · 2024-04-11T07:45:09Z

yes

So, the actual problem is when you set the keep the screen awake on, the screen is still locked after the preference locked time ends? Have you ever minimized the Neuron window?

I can not remember whether I have minimized the Neuron window.Because I have not see any tips about Neuron window operation before,so I do not pay close attention to this point.I have record a new screen recording before locking screen.
2024-04-11.14.02.37.mov
After half an hour:
2024-04-11.14.30.43.mov
main.log
And after half an hour I will offer a sync process picture.

To test this PR, I suggest setting the Computer's locked time to 1 minute, but not half an hour, then we will test this PR quickly but not need to wait for half an hour.

1 minute can not see sync process clearly,sometimes sync can not sync quickly before.

yanguoyu · 2024-04-11T07:49:13Z

yes

So, the actual problem is when you set the keep the screen awake on, the screen is still locked after the preference locked time ends? Have you ever minimized the Neuron window?

I can not remember whether I have minimized the Neuron window.Because I have not see any tips about Neuron window operation before,so I do not pay close attention to this point.I have record a new screen recording before locking screen.
2024-04-11.14.02.37.mov
After half an hour:
2024-04-11.14.30.43.mov
main.log
And after half an hour I will offer a sync process picture.

To test this PR, I suggest setting the Computer's locked time to 1 minute, but not half an hour, then we will test this PR quickly but not need to wait for half an hour.

1 minute can not see sync process clearly,sometimes sync can not sync quickly before.

I can not get the point, this PR is to avoid the screen locked when the switch opens.
IMO, to test the sync with the lock screen, it's unnecessary to use this package. Another package can also test that case.

silySuper · 2024-04-11T07:49:21Z

I click wrong

silySuper · 2024-04-11T08:38:36Z

yes

So, the actual problem is when you set the keep the screen awake on, the screen is still locked after the preference locked time ends? Have you ever minimized the Neuron window?

I can not remember whether I have minimized the Neuron window.Because I have not see any tips about Neuron window operation before,so I do not pay close attention to this point.I have record a new screen recording before locking screen.
2024-04-11.14.02.37.mov
After half an hour:
2024-04-11.14.30.43.mov
main.log
And after half an hour I will offer a sync process picture.

To test this PR, I suggest setting the Computer's locked time to 1 minute, but not half an hour, then we will test this PR quickly but not need to wait for half an hour.

1 minute can not see sync process clearly,sometimes sync can not sync quickly before.

I can not get the point, this PR is to avoid the screen locked when the switch opens. IMO, to test the sync with the lock screen, it's unnecessary to use this package. Another package can also test that case.

what does this mean?

yanguoyu requested review from Keith-CY, devchenyan, homura and silySuper March 9, 2024 13:22

yanguoyu mentioned this pull request Mar 9, 2024

Support keeping screen awake Magickbase/neuron-public-issues#319

Closed

devchenyan approved these changes Mar 10, 2024

View reviewed changes

homura approved these changes Apr 3, 2024

View reviewed changes

Comment thread packages/neuron-ui/src/utils/wakeScreen.ts

feat: Keep screen awake

6017a74

yanguoyu force-pushed the feat-keep-awake branch from ddf311a to 6017a74 Compare April 8, 2024 12:32

silySuper approved these changes Apr 11, 2024

View reviewed changes

yanguoyu requested a review from silySuper April 11, 2024 07:49

silySuper approved these changes Apr 12, 2024

View reviewed changes

Keith-CY added this pull request to the merge queue Apr 12, 2024

Merged via the queue into nervosnetwork:develop with commit 3d3e767 Apr 12, 2024

yanguoyu deleted the feat-keep-awake branch April 12, 2024 07:59

Keith-CY mentioned this pull request Apr 14, 2024

Release v0.114.3 #3124

Closed

yanguoyu mentioned this pull request Apr 15, 2024

Release v0.114.3 #3127

Merged

Uh oh!

Conversation

yanguoyu commented Mar 9, 2024

Uh oh!

Danie0918 commented Apr 1, 2024

Uh oh!

Uh oh!

Keith-CY commented Apr 9, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Keith-CY commented Apr 10, 2024

Uh oh!

silySuper commented Apr 10, 2024

Uh oh!

silySuper commented Apr 10, 2024

Uh oh!

yanguoyu commented Apr 11, 2024

Uh oh!

silySuper commented Apr 11, 2024

Uh oh!

yanguoyu commented Apr 11, 2024

Uh oh!

silySuper commented Apr 11, 2024

Uh oh!

yanguoyu commented Apr 11, 2024

Uh oh!

silySuper commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yanguoyu commented Apr 11, 2024

Uh oh!

silySuper commented Apr 11, 2024

Uh oh!

yanguoyu commented Apr 11, 2024

Uh oh!

silySuper commented Apr 11, 2024

Uh oh!

silySuper commented Apr 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Keith-CY commented Apr 9, 2024 •

edited by github-actions Bot

Loading

silySuper commented Apr 11, 2024 •

edited

Loading