Skip to content

Fix cell manage with hard wallet#3069

Merged
yanguoyu merged 2 commits into
nervosnetwork:developfrom
yanguoyu:fix-cell-manage-with-hard-wallet
Mar 14, 2024
Merged

Fix cell manage with hard wallet#3069
yanguoyu merged 2 commits into
nervosnetwork:developfrom
yanguoyu:fix-cell-manage-with-hard-wallet

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor
  1. Support lock or unlock when using a hard wallet
verify-ledger.mov
  1. Show the tx hash in the cell info dialog
image

@yanguoyu
yanguoyu force-pushed the fix-cell-manage-with-hard-wallet branch from 45aa142 to 61524a3 Compare March 13, 2024 03:51
@Danie0918

Copy link
Copy Markdown

@devchenyan @homura @Keith-CY Please have a review.

@homura

homura commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

IMO, it is best to minimize the use of passwords or hardware to reduce the risk of exposing private keys

I am not sure whether it is essential to logically unlock client-side cells through a hardware device since these cells are not physically locked but rather prevented from being spent by the wallet

@yanguoyu

Copy link
Copy Markdown
Contributor Author

IMO, it is best to minimize the use of passwords or hardware to reduce the risk of exposing private keys

I am not sure whether it is essential to logically unlock client-side cells through a hardware device since these cells are not physically locked but rather prevented from being spent by the wallet

Magickbase/neuron-public-issues#218 (comment) This the suggestion from the PM

Comment thread packages/neuron-ui/src/components/CellManagement/hooks.ts Outdated
@yanguoyu
yanguoyu force-pushed the fix-cell-manage-with-hard-wallet branch from 61524a3 to 32fac32 Compare March 13, 2024 13:10
@yanguoyu
yanguoyu requested a review from Keith-CY March 13, 2024 13:11
@silySuper

silySuper commented Mar 14, 2024

Copy link
Copy Markdown

/package
Packaging for test is done in 8274137465. @silySuper

@yanguoyu
yanguoyu added this pull request to the merge queue Mar 14, 2024
Merged via the queue into nervosnetwork:develop with commit 4055ab6 Mar 14, 2024
@yanguoyu
yanguoyu deleted the fix-cell-manage-with-hard-wallet branch March 14, 2024 04:44
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
* fix: Adapt hard wallet for lock and unlock live cell.

* fix: Add tx hash for cell info dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants