refactor: replace shannonToCKB with lumos formatUnit - #3111
Closed
twhy wants to merge 2 commits into
Closed
Conversation
Contributor
|
Looks good. Since version 0.22, Lumos has provided an entry package import { formatUnit } from '@ckb-lumos/lumos/utils'
formatUnit(...)
// or
import { utils } from '@ckb-lumos/lumos'
utils.formatUnit(...) |
Contributor
Author
|
@homura That's very convinient! But the neuron-wallet is still using Also, the lumos package has not exported So to keep this PR simple, we probably should create a separate PR to upgrade the lumos dependencies and update the imports after this one get merged. |
homura
approved these changes
Apr 9, 2024
Keith-CY
reviewed
Apr 9, 2024
Keith-CY
reviewed
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How this PR was implemented
shannonToCKBwith@ckb-lumos/bi/formatUnitas below.shannonToCKB.test.tsto make sure the new implementation pass all tests.to-csv-row.ts(the only file usingshannonToCKB), rewriteas
BigInt('')andBigInt('0')are both evaluated to0n, butBigInt('0')is more explicit.shannonToCKB.tsandshannonToCKB.test.ts