Skip to content

refactor: rewrite shannonToCKB with lumos formatUnit #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-CY merged 1 commit into from
Apr 11, 2024
Merged

refactor: rewrite shannonToCKB with lumos formatUnit #3114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions packages/neuron-wallet/src/utils/shannonToCKB.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
const DECIMAL = 8
import { formatUnit, ckbDecimals } from '@ckb-lumos/bi'

const shannonToCKB = (shannon: bigint) => {
if (shannon === BigInt(0)) {
return `+0.${'0'.repeat(DECIMAL)}`
}

const isNegative = shannon < 0
const absStr = isNegative ? `${shannon}`.slice(1) : `${shannon}`
if (absStr.length <= DECIMAL) {
return `${isNegative ? '-' : '+'}0.${absStr.padStart(DECIMAL, '0')}`
}
const int = absStr.slice(0, -1 * DECIMAL)
const dec = absStr.slice(-1 * DECIMAL)
return `${isNegative ? '-' : '+'}${int}.${dec}`
return new Intl.NumberFormat('en-US', {
useGrouping: false,
signDisplay: 'always',
minimumFractionDigits: ckbDecimals,
maximumFractionDigits: ckbDecimals,
}).format(formatUnit(shannon, 'ckb') as any)
Comment thread
yanguoyu marked this conversation as resolved.
}

export default shannonToCKB
2 changes: 1 addition & 1 deletion packages/neuron-wallet/src/utils/to-csv-row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const toCSVRow = (
txType = +tx.sudtInfo.amount <= 0 ? `UDT ${SEND_TYPE}` : `UDT ${RECEIVE_TYPE}`
}
} else {
amount = shannonToCKB(BigInt(tx.value ?? ''))
amount = shannonToCKB(BigInt(tx.value ?? '0'))
if (tx.nervosDao) {
txType = `Nervos DAO`
} else if (['create', 'destroy'].includes(tx.type || '')) {
Expand Down