refactor: rewrite sudtValueToAmount with formatUnit in neuron-ui - #3126
Merged
Keith-CY merged 2 commits intoApr 16, 2024
Merged
Conversation
Keith-CY
approved these changes
Apr 15, 2024
homura
reviewed
Apr 16, 2024
homura
approved these changes
Apr 16, 2024
Co-authored-by: homura <homura.dev@gmail.com>
yanguoyu
approved these changes
Apr 16, 2024
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fourth param
separator = ','has been replaced byshowCommaSeparator = trueto make things simpler.In our use cases, we just need to control show/hide commas in numbers, instead of customizing the separator.
Delegating the work to
Intl.NumerFormatmake the code simpler.