Skip to content

feat: Add a window/dialog after successful transaction actions - #3131

Merged
devchenyan merged 14 commits into
developfrom
fix-362
May 6, 2024
Merged

feat: Add a window/dialog after successful transaction actions#3131
devchenyan merged 14 commits into
developfrom
fix-362

Conversation

@devchenyan

Copy link
Copy Markdown
Contributor

issue: Magickbase/neuron-public-issues#362

Screen-2024-04-17-222418.mp4

@yanguoyu
yanguoyu requested a review from homura April 17, 2024 23:21
@Danie0918

Copy link
Copy Markdown

@homura @yanguoyu Please have a review.

Comment thread packages/neuron-ui/src/locales/en.json Outdated
Comment thread packages/neuron-ui/src/locales/en.json Outdated
Comment thread packages/neuron-ui/src/locales/zh-tw.json Outdated
Comment thread packages/neuron-ui/src/locales/zh.json Outdated
Comment thread packages/neuron-ui/src/locales/zh-tw.json Outdated
Comment thread packages/neuron-ui/src/locales/zh.json Outdated
Comment thread packages/neuron-ui/src/widgets/Icons/SortV2.svg
@devchenyan
devchenyan requested a review from Keith-CY April 18, 2024 03:20
@Keith-CY

Keith-CY commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

/package
Packaging for test is done in 8732073583. @Keith-CY

Comment thread packages/neuron-ui/src/components/DepositRulesDialog/index.tsx
@silySuper

silySuper commented Apr 19, 2024

Copy link
Copy Markdown

/package
Packaging for test is done in 8746928453. @silySuper

@silySuper

Copy link
Copy Markdown

1.when less than 1hour, here shows 0 hours.
截屏2024-04-19 15 45 07

截屏2024-04-19 15 20 39 截屏2024-04-19 15 20 44

2.UI is different from design
actual:
截屏2024-04-19 15 23 31

截屏2024-04-19 15 26 00

design:
截屏2024-04-19 15 48 23

@silySuper

Copy link
Copy Markdown

@devchenyan please check this~

@devchenyan

devchenyan commented Apr 29, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 8879325711. @devchenyan

@silySuper

silySuper commented Apr 30, 2024

Copy link
Copy Markdown

when unlock is grey,it should like this:
image

When lock is green ,and after click unlock it should like this:
image

@devchenyan

@devchenyan

devchenyan commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 8888711459. @devchenyan

@silySuper

Copy link
Copy Markdown
截屏2024-04-30 14 24 48 this does not fix @devchenyan

@devchenyan

devchenyan commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 8893139040. @devchenyan

@devchenyan
devchenyan added this pull request to the merge queue May 6, 2024
Merged via the queue into develop with commit f8e204f May 6, 2024
@devchenyan
devchenyan deleted the fix-362 branch May 6, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants