refactor: replace toUint64Le, parseEpoch from ckbCore.utils with lumos - #3138
Merged
Keith-CY merged 1 commit intoMay 6, 2024
Merged
refactor: replace toUint64Le, parseEpoch from ckbCore.utils with lumos#3138Keith-CY merged 1 commit into
Keith-CY merged 1 commit into
Conversation
Contributor
|
While refactoring, it is better to keep the declare const originalCkbCore;
export const ckbCore = {
someMethod: originalCkbCore.someMethod.bind(originalCkbCore),
// ...
utils: {
toUint64() {
// return ...
}
}
} |
Contributor
Author
@homura After checking the code, I realized we probably don't need to add a proxy The
|
Keith-CY
approved these changes
Apr 30, 2024
yanguoyu
approved these changes
Apr 30, 2024
homura
approved these changes
Apr 30, 2024
devchenyan
approved these changes
Apr 30, 2024
Contributor
Author
|
@Keith-CY Let's merge this. |
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.