refactor: replace ckbCore with lumos CKBRPC - #3145
Merged
Keith-CY merged 1 commit intoMay 9, 2024
Merged
Conversation
homura
approved these changes
May 9, 2024
Keith-CY
approved these changes
May 9, 2024
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CKBRPC.createBatchRequest()in Lumos currently has limited typing info:anySo in this PR I manually added response types in
thenblocks forCKBRPC.createBatchRequestcalls, e.g.I'm working on another PR for Lumos to bring back the right types for
CKBRPC.createBatchRequest()packages/neuron-ui/src/components/WithdrawDialog/index.tsxas CKBComponents.CellOutputis added becausecalculateMaximumWithdrawexpectsCKBComponents.CellOutputwhosescript.hashTypeis'data' | 'type' | 'data1'tx.transaction.outputsmember has typeOutputwhosescript.hashTypeis"type" | "data" | "data1" | "data2"as CKBComponents.CellOutputwill be removed in next PR, which I will replace@nervosnetwork/ckb-sdk-utilsmethods with Lumos methods.@nervosnetwork/ckb-sdk-coreis removed fromdependenciesofneurons-ui.