Skip to content

refactor: refactor models/multisig with lumos - #3156

Merged
Keith-CY merged 5 commits into
nervosnetwork:developfrom
twhy:refactor-multisig-with-lumos
May 21, 2024
Merged

refactor: refactor models/multisig with lumos#3156
Keith-CY merged 5 commits into
nervosnetwork:developfrom
twhy:refactor-multisig-with-lumos

Conversation

@twhy

@twhy twhy commented May 20, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@twhy

twhy commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

@Keith-CY Please trigger workflows and review this when you're available.

Comment thread packages/neuron-wallet/src/models/multisig.ts Outdated
@Keith-CY

Keith-CY commented May 21, 2024

Copy link
Copy Markdown
Contributor

/package
Packaging for test is done in 9169990204. @Keith-CY

@twhy

twhy commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

The original commit was signed but maybe the rebase made it unsigned.
image

@Keith-CY

Copy link
Copy Markdown
Contributor

The original commit was signed but maybe the rebase made it unsigned. image

Feel free to force-push to override the unsigned commit

twhy and others added 5 commits May 21, 2024 19:10
Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>
Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>
Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>
@twhy

twhy commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

@Keith-CY This PR can be merged now, maybe run the workflows once more.

@Keith-CY
Keith-CY added this pull request to the merge queue May 21, 2024
Merged via the queue into nervosnetwork:develop with commit 590dc0d May 21, 2024
@twhy
twhy deleted the refactor-multisig-with-lumos branch May 21, 2024 11:18
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request May 29, 2024
* refactor: refactor models/multisig with lumos

Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>

* refactor: move BLAKE160_HEX_LENGTH to blake2b.ts

Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>

* feat: Add help link for sync failed.

Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>

* ci: upgrade github actions version (nervosnetwork#3161)

Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>

---------

Signed-off-by: Tom Wang <tom.wanghaiyi@gmail.com>
Co-authored-by: yanguoyu <841185308@qq.com>
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants