feat: compatible ckb-cli tx multisig file by devchenyan · Pull Request #3169 · nervosnetwork/neuron

devchenyan · 2024-05-26T18:18:07Z

issue: Magickbase/neuron-public-issues#377

ckb-cli tx multisig file:
transaction_cli.json

Screen-2024-05-27-021744.mp4

Danie0918 · 2024-05-27T02:54:34Z

@homura Please have a review.

devchenyan · 2024-05-27T07:37:52Z

/package
Packaging for test is done in 9251063539. @devchenyan

Danie0918 · 2024-05-30T01:20:46Z

@homura Please have a review.

Danie0918 · 2024-06-05T01:32:43Z

@Keith-CY @homura Please have a review.

silySuper · 2024-06-05T03:02:57Z

/package
Packaging for test is done in 9377511492. @silySuper

silySuper · 2024-06-06T02:05:08Z

/package
Packaging for test is done in 9393978809. @silySuper

silySuper · 2024-06-07T01:56:51Z

1.Click confirm button firstly,then click send will cause network reconnect.

2024-06-07.09.49.59.mov

2.After click confirm button ,pop up window does not show confirm button ,but only shows cancel button.

2024-06-07.09.48.59.mov

devchenyan · 2024-06-07T03:36:14Z

1.Click confirm button firstly,then click send will cause network reconnect.

2024-06-07.09.49.59.mov
2.After click confirm button ,pop up window does not show confirm button ,but only shows cancel button.

2024-06-07.09.48.59.mov

2、Multi-signing requires other accounts to have completed signing before the confirm button is available.

devchenyan · 2024-06-07T03:40:15Z

/package
Packaging for test is done in 9411294269. @devchenyan

devchenyan · 2024-06-07T03:55:44Z

@silySuper 1、 fixed

feat: compatible ckb-cli tx multisig file

3677308

devchenyan requested review from Keith-CY, homura and yanguoyu May 26, 2024 18:18

devchenyan mentioned this pull request May 26, 2024

The ckb-cli tx multisig tx file is not compatible with Neuron Magickbase/neuron-public-issues#377

Closed

yanguoyu reviewed May 27, 2024

View reviewed changes

Comment thread packages/neuron-wallet/src/utils/hump.ts Outdated

Comment thread packages/neuron-wallet/src/utils/multisig.ts Outdated

fix: comments

5bfb707

devchenyan requested a review from yanguoyu May 27, 2024 03:55

yanguoyu approved these changes May 27, 2024

View reviewed changes

homura reviewed May 28, 2024

View reviewed changes

Comment thread packages/neuron-wallet/src/utils/json-to-hump.ts Outdated

Comment thread packages/neuron-wallet/src/utils/json-to-hump.ts Outdated

Comment thread packages/neuron-wallet/src/utils/json-to-hump.ts Outdated

fix: comments

625a274

Danie0918 requested a review from twhy May 30, 2024 01:20

Keith-CY reviewed May 30, 2024

View reviewed changes

Comment thread packages/neuron-wallet/src/controllers/multisig.ts Outdated

Comment thread packages/neuron-wallet/src/models/chain/cell-dep.ts Outdated

Comment thread packages/neuron-wallet/src/utils/deep-camelize-keys.ts Outdated

devchenyan added 3 commits June 1, 2024 13:46

fix: comments

4aad5da

Merge branch 'develop' into feat-377

2a9d12a

fix

d4a5e51

devchenyan force-pushed the feat-377 branch from c3889fa to d4a5e51 Compare June 1, 2024 07:46

Keith-CY reviewed Jun 5, 2024

View reviewed changes

Comment thread packages/neuron-wallet/src/models/chain/cell-dep.ts Outdated

devchenyan added 2 commits June 5, 2024 10:51

fix

d0e6363

Merge branch 'develop' into feat-377

d61fc89

Keith-CY approved these changes Jun 5, 2024

View reviewed changes

devchenyan requested review from homura and silySuper June 5, 2024 03:00

homura approved these changes Jun 5, 2024

View reviewed changes

Comment thread packages/neuron-wallet/src/models/chain/cell-dep.ts Outdated

Comment thread packages/neuron-wallet/src/utils/multisig.ts Outdated

fix

a638795

devchenyan added 2 commits June 5, 2024 23:06

Merge remote-tracking branch

4970c0b

Merge branch 'develop' into feat-377

8f33040

fix

a6201d4

Keith-CY mentioned this pull request Jun 7, 2024

The ckb-cli tx multisig tx file is not compatible with Neuron #3048

Closed

silySuper approved these changes Jun 7, 2024

View reviewed changes

Keith-CY merged commit 77d99fb into develop Jun 7, 2024

Keith-CY deleted the feat-377 branch June 7, 2024 08:26

Keith-CY mentioned this pull request Aug 8, 2024

Release v0.117.0 #3228

Merged

Uh oh!

Conversation

devchenyan commented May 26, 2024

Uh oh!

Uh oh!

Uh oh!

Danie0918 commented May 27, 2024

Uh oh!

devchenyan commented May 27, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Danie0918 commented May 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Danie0918 commented Jun 5, 2024

Uh oh!

Uh oh!

silySuper commented Jun 5, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silySuper commented Jun 6, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silySuper commented Jun 7, 2024

Uh oh!

devchenyan commented Jun 7, 2024

Uh oh!

devchenyan commented Jun 7, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devchenyan commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

devchenyan commented May 27, 2024 •

edited by github-actions Bot

Loading

silySuper commented Jun 5, 2024 •

edited by github-actions Bot

Loading

silySuper commented Jun 6, 2024 •

edited by github-actions Bot

Loading

devchenyan commented Jun 7, 2024 •

edited by github-actions Bot

Loading