fix: Show the tip of looking for valid target - #3195
Merged
Keith-CY merged 1 commit intoJun 24, 2024
Conversation
yanguoyu
force-pushed
the
fix-show-look-valid-target
branch
3 times, most recently
from
June 21, 2024 02:30
6a24950 to
1616a0a
Compare
Keith-CY
reviewed
Jun 21, 2024
yanguoyu
force-pushed
the
fix-show-look-valid-target
branch
from
June 21, 2024 02:50
1616a0a to
63c90d3
Compare
|
@devchenyan @homura @twhy Please have a review. |
devchenyan
approved these changes
Jun 24, 2024
Keith-CY
approved these changes
Jun 24, 2024
Contributor
|
/package |
Contributor
|
The note 
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Magickbase/neuron-public-issues#398
Currently, use the
sync_statusto get thebest_known_block_number, and check whether thebest_known_block_numberis less than theassume-valid-target blocknumber.After nervosnetwork/ckb#4486 merged, use RPC result to check the status