Skip to content

fix: For windows os the user need to start the Neuron manually after installed. - #3196

Merged
yanguoyu merged 1 commit into
nervosnetwork:developfrom
yanguoyu:fix-auto-open
Jun 26, 2024
Merged

fix: For windows os the user need to start the Neuron manually after installed.#3196
yanguoyu merged 1 commit into
nervosnetwork:developfrom
yanguoyu:fix-auto-open

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

@yanguoyu yanguoyu changed the title fix: Force run after install new version fix: For windows os the user need to start the Neuron manually after installed. Jun 21, 2024
@yanguoyu
yanguoyu marked this pull request as ready for review June 21, 2024 09:26
@Danie0918

Copy link
Copy Markdown

@homura @twhy Please have a review.

@silySuper

silySuper commented Jun 25, 2024

Copy link
Copy Markdown

/package

Packaging for test is done in 9658210868. @silySuper

@silySuper

silySuper commented Jun 25, 2024

Copy link
Copy Markdown
截屏2024-06-25 16 41 32 截屏2024-06-25 16 50 48

@yanguoyu

yanguoyu commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

截屏2024-06-25 16 41 32 截屏2024-06-25 16 50 48

Magickbase/neuron-public-issues#397 (comment) and notice the PR title

@silySuper

silySuper commented Jun 26, 2024

Copy link
Copy Markdown
    confirmText={t(`updates.${isWin ? 'quit-and-install-restart' : 'quit-and-install'}`)}

if iswin true shows quit-and-install-restart,if not shows quit-and-install
so when iswin,expect to show relaunch or not ?

@yanguoyu
yanguoyu added this pull request to the merge queue Jun 26, 2024
Merged via the queue into nervosnetwork:develop with commit 4493d79 Jun 26, 2024
@yanguoyu
yanguoyu deleted the fix-auto-open branch June 26, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants