Skip to content

fix: remove CRs when inject environment variables - #3236

Merged
Keith-CY merged 1 commit into
rc/v0.117.0from
remove-unexpected-cr
Aug 12, 2024
Merged

fix: remove CRs when inject environment variables #3236
Keith-CY merged 1 commit into
rc/v0.117.0from
remove-unexpected-cr

Conversation

@Keith-CY

@Keith-CY Keith-CY commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

Injecting environment variables with CR makes the key mismatched.

Inject environment variables with `CR` makes the key mismatched.
@Keith-CY

Copy link
Copy Markdown
Contributor Author

@homura homura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or can we inject an empty line like this?

echo "\n" >> packages/neuron-wallet/.env
echo "LOG_ENCRYPTION_PUBLIC_KEY=${{ secrets.LOG_ENCRYPTION_PUBLIC_KEY }}" >> packages/neuron-wallet/.env

@Keith-CY

Copy link
Copy Markdown
Contributor Author

Or can we inject an empty line like this?

echo -en "\n"
echo "LOG_ENCRYPTION_PUBLIC_KEY=${{ secrets.LOG_ENCRYPTION_PUBLIC_KEY }}" >> packages/neuron-wallet/.env

This line is injected when the app is being packaged, IMO it's unnecessary to add the empty line

@Keith-CY

Copy link
Copy Markdown
Contributor Author

Please have a review @yanguoyu @devchenyan

@Keith-CY
Keith-CY merged commit 19b23bf into rc/v0.117.0 Aug 12, 2024
@Keith-CY
Keith-CY deleted the remove-unexpected-cr branch August 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants