Skip to content

feat: Support UDT destruction - #3323

Merged
devchenyan merged 10 commits into
developfrom
feat-420
Mar 6, 2025
Merged

feat: Support UDT destruction#3323
devchenyan merged 10 commits into
developfrom
feat-420

Conversation

@devchenyan

@devchenyan devchenyan commented Feb 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

issue:

1.mov
  • Cell Management
2.mov
  • HardWallet
Screen-2025-02-27-181813.mp4

@Danie0918
Danie0918 requested review from Keith-CY and yanguoyu and removed request for Keith-CY and yanguoyu February 27, 2025 07:12
@devchenyan
devchenyan marked this pull request as ready for review February 27, 2025 10:00
@devchenyan devchenyan mentioned this pull request Feb 27, 2025
Open
Keith-CY
Keith-CY reviewed Feb 28, 2025
View reviewed changes
Comment thread packages/neuron-wallet/src/controllers/api.ts Outdated
Comment thread packages/neuron-wallet/src/models/system-script-info.ts Outdated
Comment thread packages/neuron-wallet/src/services/tx/transaction-generator.ts Outdated
Comment thread packages/neuron-wallet/src/controllers/sudt.ts Outdated
@yanguoyu

yanguoyu commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

Could you upload a screenshot of recycling the cell in the cell-management page? I get that we can recycle selected cells but here https://github.com/nervosnetwork/neuron/pull/3323/files#diff-d920ea38b5341527c5912ada1449a2808d5319f9e731cf26b61684f50552608bR396-R398 only transfer one token.

@devchenyan

devchenyan commented Feb 28, 2025

Copy link
Copy Markdown
Contributor Author

Could you upload a screenshot of recycling the cell in the cell-management page? I get that we can recycle selected cells but here https://github.com/nervosnetwork/neuron/pull/3323/files#diff-d920ea38b5341527c5912ada1449a2808d5319f9e731cf26b61684f50552608bR396-R398 only transfer one token.

The wrong video was uploaded earlier, and the video has now been updated.

image

@devchenyan
devchenyan requested a review from Keith-CY February 28, 2025 08:32
yanguoyu
yanguoyu reviewed Mar 3, 2025
View reviewed changes
Comment thread packages/neuron-ui/src/components/RecycleUDTCellDialog/index.tsx
Comment thread packages/neuron-ui/src/components/RecycleUDTCellDialog/index.tsx Outdated
Comment thread packages/neuron-ui/src/components/RecycleUDTCellDialog/index.tsx Outdated
@silySuper

silySuper commented Mar 3, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package
Packaging for test is done in 13625134889. @silySuper

@silySuper

silySuper commented Mar 4, 2025 •
edited
Loading

Copy link
Copy Markdown

1.When destroy 0.0 udt ,it shows +,inexpect it should shows -
截屏2025-03-04 11 32 05

@silySuper

silySuper commented Mar 5, 2025

Copy link
Copy Markdown

link issue：Magickbase/neuron-public-issues#445

@devchenyan

devchenyan commented Mar 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

1.When destroy 0.0 udt ,it shows +,inexpect it should shows - 截屏2025-03-04 11 32 05

fixed. @silySuper
image

@silySuper

silySuper commented Mar 6, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package
Packaging for test is done in 13689829089. @silySuper

@devchenyan
devchenyan added this pull request to the merge queue Mar 6, 2025
Merged via the queue into develop with commit ecd4095 Mar 6, 2025
@devchenyan
devchenyan deleted the feat-420 branch March 6, 2025 03:43
@Keith-CY Keith-CY mentioned this pull request May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@homura homura Awaiting requested review from homura
3 more reviewers
@Keith-CY Keith-CY Keith-CY approved these changes
@yanguoyu yanguoyu yanguoyu approved these changes
@silySuper silySuper silySuper approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devchenyan @yanguoyu @silySuper @Keith-CY