Skip to content

chore(codeowners): add three owners and remove two - #108

Merged
leoparente merged 1 commit into
developfrom
chore/add-codeowners
Aug 21, 2026
Merged

chore(codeowners): add three owners and remove two#108
leoparente merged 1 commit into
developfrom
chore/add-codeowners

Conversation

@leoparente

@leoparente leoparente commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Refreshes the code owner list for this SDK.

-* @jajeffries @leoparente @ltucker @mfiedorowicz @MicahParks @davidlanouette
+* @jajeffries @leoparente @mfiedorowicz @davidlanouette @paulstuart @samiura @manrodrigues

Added — all three already own code in orb-agent, which consumes this SDK, so reviews here reach them too:

Handle Name
@paulstuart Paul Stuart
@samiura Samiur Arif
@manrodrigues Amanda Rodrigues

Removed:

Handle Name
@MicahParks Micah Parks
@ltucker Luke Tucker

Every handle was resolved against the GitHub user API rather than inferred, because a wrong handle in CODEOWNERS fails silently: an added one is never assigned, and a removed one strips review coverage from the wrong person. Two cases where that mattered here:

  • @mfiedorowicz is Michal Fiedorowicz, not Micah, so it stays. Both begin "Mic" and only one was meant to go.
  • Amanda Rodrigues is @manrodrigues; there is no amanda* account in the org, so a guessed handle would have been silently ignored. Confirmed by mapping her commits (arodrigues@netboxlabs.com) to that login.

Same change as netboxlabs/diode-sdk-go#86, so the two SDKs stay aligned.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
/opt/hostedtoolcache/Python/3.10.20/x64/lib/python3.10/site-packages/netboxlabs/diode/sdk
   chunking.py33197%112
   client.py5674293%202–203, 222–224, 227–230, 522, 590, 595, 599, 682–687, 732–734, 764, 768, 772, 794, 815, 817, 891, 922, 930, 992–993, 1002, 1035, 1062, 1067–1068, 1097, 1102–1105
   exceptions.py44393%69, 82–83
TOTAL6594693% 

Tests Skipped Failures Errors Time
213 0 💤 0 ❌ 0 🔥 0.985s ⏱️

@leoparente
leoparente force-pushed the chore/add-codeowners branch from a0f3010 to 9cc7352 Compare August 17, 2026 20:42
@leoparente leoparente changed the title chore(codeowners): add @paulstuart and @samiura chore(codeowners): add @paulstuart, @samiura and @manrodrigues Aug 17, 2026
Adds @paulstuart, @samiura and @manrodrigues, who already own code in
orb-agent, the consumer of this SDK, so reviews here reach them too.

Removes @MicahParks and @ltucker. Matches the same change to diode-sdk-go.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@leoparente
leoparente force-pushed the chore/add-codeowners branch from 9cc7352 to 6d54db9 Compare August 17, 2026 20:46
@leoparente leoparente changed the title chore(codeowners): add @paulstuart, @samiura and @manrodrigues chore(codeowners): add three owners and remove two Aug 17, 2026
@leoparente
leoparente merged commit 887604e into develop Aug 21, 2026
8 checks passed
@leoparente
leoparente deleted the chore/add-codeowners branch August 21, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants