Skip to content

Windows Plugin (Sensors) - #20840

Merged
thiagoftsm merged 17 commits into
netdata:masterfrom
thiagoftsm:sensors_partI
Aug 20, 2025
Merged

Windows Plugin (Sensors)#20840
thiagoftsm merged 17 commits into
netdata:masterfrom
thiagoftsm:sensors_partI

Conversation

@thiagoftsm

@thiagoftsm thiagoftsm commented Aug 19, 2025

Copy link
Copy Markdown
Contributor
Summary

This initial PR introduces sensor collection for Microsoft Windows. It uses the Windows Sensors API to gather data from five different sensor types, four of which are also supported on our Linux implementation.

sensors
Test Plan
  1. Compile this branch directly on a physical host. (Note: Most virtual machines do not have sensors.
  2. Install the build on your host machine and verify the data in the charts.
Additional Information

Tested direct on laptop with sensors

For users: How does this change affect me?

@github-actions github-actions Bot added area/collectors Everything related to data collection area/build Build system (autotools and cmake). collectors/windows labels Aug 19, 2025
@thiagoftsm
thiagoftsm marked this pull request as ready for review August 20, 2025 03:09
@thiagoftsm
thiagoftsm requested review from a team and vkalintiris as code owners August 20, 2025 03:09
@thiagoftsm
thiagoftsm requested a review from stelfrag August 20, 2025 03:09
@github-actions github-actions Bot added the area/metadata Integrations metadata label Aug 20, 2025
Comment thread src/collectors/windows.plugin/GetSensors.c Outdated
Comment thread src/collectors/windows.plugin/GetSensors.c Outdated
Comment thread src/collectors/windows.plugin/GetSensors.c Outdated
@thiagoftsm
thiagoftsm requested a review from ralphm August 20, 2025 12:08
@thiagoftsm
thiagoftsm requested a review from ilyam8 August 20, 2025 12:15
ralphm
ralphm previously approved these changes Aug 20, 2025

@ralphm ralphm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the humidity unit is addressed, this looks good to me. Can you create a PR for the charts repo?

},
{
.title = "Sensor Humidity",
.units = "percentage",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct unit is %. See paragraph 29.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@thiagoftsm

Copy link
Copy Markdown
Contributor Author

When the humidity unit is addressed, this looks good to me. Can you create a PR for the charts repo?

Yes, I will do.

@thiagoftsm
thiagoftsm enabled auto-merge (squash) August 20, 2025 14:17
@thiagoftsm
thiagoftsm merged commit 03f8c79 into netdata:master Aug 20, 2025
103 of 107 checks passed
@thiagoftsm
thiagoftsm deleted the sensors_partI branch August 20, 2025 14:33
ktsaou pushed a commit to ktsaou/netdata that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build system (autotools and cmake). area/collectors Everything related to data collection area/metadata Integrations metadata collectors/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants