chore: add YAML linting to CI#20
Conversation
Summary of ChangesHello @CybotTM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a configuration for yamllint. However, it disables several useful linting rules by default. My feedback suggests adopting a stricter configuration to ensure YAML files are consistent and to prevent potential issues. Specifically, I've recommended adjusting the line-length rule instead of disabling it, and re-enabling other rules like truthy for better code quality.
Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
GH-19, GH-20, and GH-21 now set follow_uses: true so the runner expands the searched workflow files with the contents of any reusable workflow referenced via uses: owner/repo/.github/workflows/file.yml@ref (one hop, fetched via gh api). The pattern then matches against either the local file OR the upstream content. This lets repos satisfy CodeQL/Scorecard checks by delegating to a shared reusable workflow (e.g. netresearch/typo3-ci-workflows/.github/ workflows/security.yml) instead of duplicating the github/codeql-action and ossf/scorecard-action wiring locally. The semantics are unchanged — the upstream workflow body must still actually use the named action. For GH-21 (regex_not for slsa-github-generator), follow_uses prevents hiding the deprecated generator inside a delegated workflow. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Add yamllint to the lint CI workflow to validate YAML files.