Skip to content

chore: add YAML linting to CI#20

Merged
CybotTM merged 2 commits into
mainfrom
chore/add-yamllint
Feb 15, 2026
Merged

chore: add YAML linting to CI#20
CybotTM merged 2 commits into
mainfrom
chore/add-yamllint

Conversation

@CybotTM

@CybotTM CybotTM commented Feb 15, 2026

Copy link
Copy Markdown
Member

Add yamllint to the lint CI workflow to validate YAML files.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @CybotTM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces yamllint to the continuous integration pipeline, enhancing code quality by automatically checking YAML files for common issues and style inconsistencies. This ensures that all YAML configurations adhere to a consistent standard, improving maintainability and reducing potential errors.

Highlights

  • YAML Linting Introduction: Integrated yamllint into the CI workflow to automatically validate YAML file syntax and style, ensuring consistency across the repository.
  • Configuration for yamllint: Added a .yamllint.yml configuration file to disable specific rules such as line-length, truthy, document-start, and comments-indentation for tailored linting behavior.
Changelog
  • .yamllint.yml
    • Added a new configuration file for yamllint to define linting rules.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/lint.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configuration for yamllint. However, it disables several useful linting rules by default. My feedback suggests adopting a stricter configuration to ensure YAML files are consistent and to prevent potential issues. Specifically, I've recommended adjusting the line-length rule instead of disabling it, and re-enabling other rules like truthy for better code quality.

Comment thread .yamllint.yml
@CybotTM CybotTM merged commit 22cc50a into main Feb 15, 2026
5 checks passed
@CybotTM CybotTM deleted the chore/add-yamllint branch February 15, 2026 10:26
CybotTM added a commit that referenced this pull request Mar 15, 2026
Add GH-17 through GH-20: .gitignore existence, renovate.json
alternative, CodeQL and Scorecard workflow checks.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
CybotTM added a commit that referenced this pull request Mar 28, 2026
- Re-enable truthy and comments-indentation yamllint rules (PR #20)
- Use homepage instead of url for author in plugin.json (PR #24)
- Add support section with issues and source URLs to plugin.json (PR #24)
- Add docs URL to composer.json support section (PR #24)
CybotTM added a commit that referenced this pull request Apr 24, 2026
Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
CybotTM added a commit that referenced this pull request May 5, 2026
GH-19, GH-20, and GH-21 now set follow_uses: true so the runner expands
the searched workflow files with the contents of any reusable workflow
referenced via uses: owner/repo/.github/workflows/file.yml@ref (one hop,
fetched via gh api). The pattern then matches against either the local
file OR the upstream content.

This lets repos satisfy CodeQL/Scorecard checks by delegating to a
shared reusable workflow (e.g. netresearch/typo3-ci-workflows/.github/
workflows/security.yml) instead of duplicating the github/codeql-action
and ossf/scorecard-action wiring locally. The semantics are unchanged —
the upstream workflow body must still actually use the named action.

For GH-21 (regex_not for slsa-github-generator), follow_uses prevents
hiding the deprecated generator inside a delegated workflow.

Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant