fix: GH-06 accept Renovate as alternative to Dependabot#39
Conversation
The file_exists check only looked for .github/dependabot.yml, producing false positives on repos using Renovate for dependency updates. Switch to a command check that accepts dependabot.yml, renovate.json, .github/renovate.json, .renovaterc.json, or .renovaterc. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the GH-6 checkpoint incorrectly flagged repositories using Renovate for dependency management as not having any automation configured. The change updates the checkpoint's logic to recognize both Dependabot and Renovate configuration files, ensuring accurate assessment of dependency update automation presence. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly extends the GH-06 checkpoint to support Renovate as an alternative to Dependabot for dependency management. The change from a file_exists check to a command check is appropriate for handling multiple possible configuration files. I've added one suggestion to improve the completeness and readability of the shell command used for the check.
Adds a package.json so the skill is npm-installable straight from this GitHub repo (no npm-registry publication required to start). README gains a parallel 'npm (Node Projects)' section under Installation, mirroring the existing 'Composer (PHP Projects)' section. Same pattern applied to git-workflow-skill (PR #39) and on the coordinator side at netresearch/node-agent-skill-coordinator. Version stays at 0.0.0-source until npm publication is decided separately. Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Summary
file_exists(only.github/dependabot.yml) tocommandcheck that accepts any of:dependabot.yml,renovate.json,.github/renovate.json,.renovaterc.json,.renovatercTest plan
.github/dependabot.ymlrenovate.json