LinkGenerator: allow 'test' mode in link target validation#365
Open
Lumeriol wants to merge 2 commits into
Open
LinkGenerator: allow 'test' mode in link target validation#365Lumeriol wants to merge 2 commits into
Lumeriol wants to merge 2 commits into
Conversation
The change allows the use/validation of 'test' mode over presenters containing the Requires attribute (e.g., using the isLinkCurrent method on the Error4xx presenter).
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where using isLinkCurrent() on presenters or actions marked with #[Requires(forward: true)] would incorrectly throw an "Invalid link" exception. The change allows the 'test' mode (used by isLinkCurrent()) to bypass the access policy validation, similar to how 'forward' mode already behaved.
- Modified link target validation to allow 'test' mode alongside 'forward' mode to skip
isLinkable()checks - Added
in_arrayto the imported functions list to support the new validation logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dg
force-pushed
the
v3.2
branch
3 times, most recently
from
f86203b to
8f6af0a
Compare
dg
force-pushed
the
v3.2
branch
3 times, most recently
from
5716952 to
b7d4723
Compare
dg
force-pushed
the
v3.2
branch
14 times, most recently
from
bd42656 to
cdf59b0
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change allows the use/validation of 'test' mode over presenters containing the Requires attribute (e.g., using the isLinkCurrent method on the Error4xx presenter).
This is reaction to this commit.