Relax deepdiff dependency.#101
Merged
pszulczewski merged 3 commits intoMay 12, 2023
Merged
Conversation
Kircheneer
requested review from
chadell,
jeffkala,
lvrfrc87,
pszulczewski and
scetron
as code owners
May 12, 2023 11:07
Contributor
Author
Contributor
|
this allows moving to a new major version ( |
Contributor
Author
|
Doesn't look problematic to me:
One looks like a bug fix and the other is a new feature. |
Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu>
pszulczewski
previously approved these changes
May 12, 2023
Collaborator
|
@Kircheneer you need to update poetry.lock |
Contributor
Author
|
I don't think so @pszulczewski - I am just allowing newer versions, I am not necessitating their use. |
Collaborator
|
From the CI: |
Collaborator
|
Would be nice to have it in poetry lock so CICD can run with the latest lib version an mack sure all test are ok |
Kircheneer
force-pushed
the
lk-relax-deepdiff-dependency
branch
from
May 12, 2023 12:02
6396ae8 to
a1ff40c
Compare
Contributor
Author
|
Ahh I see.. done! |
pszulczewski
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.