Updates for 0.2.0 release#12
Merged
Merged
Conversation
Move to constants, fix doctest, make dns actions more clear, clean up wording to be more clear
jeffkala
approved these changes
May 28, 2021
dgjustice
approved these changes
May 28, 2021
dgjustice
left a comment
dgjustice
left a comment
Contributor
There was a problem hiding this comment.
This addresses some of the concerns I had. The library as a whole was written hot-and-fast, so I trust the kinks will get worked out as issues are raised.
Contributor
Author
|
@dgjustice I thought I captured all of the things you have mentioned, what do you feel is missing? |
Contributor
|
@itdependsnetworks it is simply a matter of differences of opinion. It's Friday before a holiday weekend; I'm not going to be the one to hold up a release. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to constants, fix doctest, make dns actions more clear, clean up wording to be more clear