Skip to content

AppSidebar: fix tab validation: tabs are optional - #445

Merged
skjnldsv merged 1 commit into
masterfrom
sidebar-tab-validation
Jun 24, 2019
Merged

AppSidebar: fix tab validation: tabs are optional#445
skjnldsv merged 1 commit into
masterfrom
sidebar-tab-validation

Conversation

@korelstar

@korelstar korelstar commented Jun 23, 2019

Copy link
Copy Markdown
Contributor

There are two use-cases for AppSidebar:

  1. slot contains one or more AppSidebarTab(s) => use tabs
  2. slot contains custom element(s) => don't use tabs

With this PR, it is checked if one of those use-cases is used. It gives a warning, if they are mixed.

@korelstar korelstar added 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jun 23, 2019
@korelstar korelstar added this to the next milestone Jun 23, 2019
ChristophWurst
ChristophWurst approved these changes Jun 24, 2019
View reviewed changes

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@skjnldsv
skjnldsv merged commit 4fe9383 into master Jun 24, 2019
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 24, 2019
@skjnldsv
skjnldsv deleted the sidebar-tab-validation branch June 24, 2019 10:53
@skjnldsv skjnldsv mentioned this pull request Jun 26, 2019
Merged
@skjnldsv
skjnldsv restored the sidebar-tab-validation branch June 26, 2019 12:22
@skjnldsv
skjnldsv deleted the sidebar-tab-validation branch June 26, 2019 12:24
@skjnldsv skjnldsv removed this from the next milestone Jul 10, 2019
@korelstar korelstar mentioned this pull request Jul 12, 2019
Closed
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes
@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: app-sidebar Related to the app-sidebar component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@korelstar @ChristophWurst @skjnldsv