Skip to content

Fix translation ignore#888

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/fix-translation-ignore
Aug 24, 2022
Merged

Fix translation ignore#888
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/fix-translation-ignore

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Ref #880 (comment)

Current error:

Those files are ignored:
Array
(
[0] => js/activity-*
[1] => js/templates.js
)
/app/js/activity-adminSettings.js:2: warning: Empty msgid. It is reserved by GNU gettext:
gettext("") returns the header entry with
meta information, not the empty string.

Tested locally and it works now.

Signed-off-by: Joas Schilling <coding@schilljs.com>

@rakekniven rakekniven left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to document this behaviour.

@nickvergessen nickvergessen marked this pull request as ready for review August 24, 2022 07:13
@nickvergessen nickvergessen merged commit 9645a92 into master Aug 24, 2022
@delete-merged-branch delete-merged-branch Bot deleted the bugfix/noid/fix-translation-ignore branch August 24, 2022 07:13
@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable24

@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable23

@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants