fix: show and update teamAvatar - #2782
Conversation
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Janina Hiob <janina.hiob@dataport.de>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| } | ||
|
|
||
| onMounted(() => { | ||
| loadAvatarUrl() |
There was a problem hiding this comment.
Only runs on mount, but TeamPage likely reuses this component when you switch teams, so the header keeps the previous team's picture? Likely needs a watch on circleId. (or a key to force remount)
There was a problem hiding this comment.
a watch on cirlceId is added
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Janina Hiob <janina.hiob@dataport.de>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
In the
TeamAvatar.vuethe NcAvatar was missing theavatarUrl. The generation of the avatarUrl was copied from the removed criclesUI from the contacts app.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)