Skip to content

[stable13] Enable full screen mode for PDF files - #59

Merged
MorrisJobke merged 1 commit into
stable13from
stable13-57-enable-fullscreen-mode-for-pdf-files
Mar 9, 2018
Merged

MorrisJobke merged 1 commit into
stable13from
stable13-57-enable-fullscreen-mode-for-pdf-files

Conversation

@danxuliu

@danxuliu danxuliu commented Mar 9, 2018

Copy link
Copy Markdown
Member

Backport of #57

The PDF viewer provides a "Full screen" button when it detects that the
browser supports the full screen mode and that the PDF is inside an
element that can be displayed full screen. Therefore, as the PDF viewer
is shown inside an "iframe" element its "allowfullscreen" attribute must
be set to "true".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added this to the Nextcloud 13.0.1 milestone Mar 9, 2018
@danxuliu
danxuliu requested review from MorrisJobke and rullzer March 9, 2018 11:15
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
10 tasks done
@MorrisJobke
MorrisJobke merged commit 13f70c8 into stable13 Mar 9, 2018
@MorrisJobke
MorrisJobke deleted the stable13-57-enable-fullscreen-mode-for-pdf-files branch March 9, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants